Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix admin redesign in blogs module #11642

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Conversation

alecslupu
Copy link
Contributor

@alecslupu alecslupu commented Sep 22, 2023

馃帺 What? Why?

This PR solves some of the design issues signaled in #11601

馃搶 Related Issues

Link your PR to an issue

Testing

  1. Login as admin and visit blogs admin panel
  2. Check the elements in the associated ticket
  3. Apply the patch
  4. See the elements in the list being changed

馃摲 Screenshots

Please add screenshots of the changes you are proposing
Description

鈾ワ笍 Thank you!

@alecslupu alecslupu added module: blogs type: fix PRs that implement a fix for a bug no-backport Pull Requests that should not be backported labels Sep 22, 2023
@alecslupu alecslupu added this to the 0.28.0 milestone Sep 22, 2023
@alecslupu alecslupu added contract: redesign Barcelona City Council contract and removed no-backport Pull Requests that should not be backported labels Sep 22, 2023
@alecslupu alecslupu requested a review from a team September 23, 2023 19:25
@alecslupu alecslupu marked this pull request as ready for review September 23, 2023 19:25
Copy link
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤馃徑

@andreslucena
Copy link
Member

@alecslupu for me this could be merged as is, the only doubt that I had is what you meant with " Extra pagination param" in the original issue? This empty sidebar thing?
Screenshot of the admin in the blog module

@alecslupu
Copy link
Contributor Author

" Extra pagination param"

It refers to an extra parameter passed to the decidim_paginate, which actually added an extra parameter to query string.
used to be:

<%= decidim_paginate @posts, theme: "decidim" %>

which would have been translated to an url like: /blogs/index?page=1&theme=decidim.

However most of those have been tracked and solved by redesign team in the scope of #11144 , within PR fdc0a37

@alecslupu
Copy link
Contributor Author

for me this could be merged as is,

Merging as per @andreslucena 's input:

@alecslupu alecslupu merged commit 28d00c3 into develop Sep 26, 2023
33 checks passed
@alecslupu alecslupu deleted the fix/admin-blogs-redesign branch September 26, 2023 18:58
@alecslupu alecslupu added the no-backport Pull Requests that should not be backported label Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contract: redesign Barcelona City Council contract module: blogs no-backport Pull Requests that should not be backported type: fix PRs that implement a fix for a bug
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Admin blogs Issues
2 participants