Redesign: admin

[jorgeatgu]

🎩 What? Why?

This PR implements the redesign in admin

📌 Related Issues

• Closes Admin Redesign: Fixed action buttons in bottom #11199
• Closes Redesign Admin: Polls in meetings #11445
• Closes Redesign: Fix elections admin remaining tests #11569

Testing

The URL is a bit different for the admin, but the credentials and db are the same.

Admin staging: https://decidim-redesign-admin.populate.tools/admin/
Participatory processes: https://decidim-redesign-admin.populate.tools/admin/participatory_processes
Settings: https://decidim-redesign-admin.populate.tools/admin/organization/edit

♥️ Thank you!

Feedback @alecslupu:

• When using a big screen, i have the feeling the admin is unfinished
• Elections Voter feedback fields (answers) does not support translated fields.
• Adding a Service to a meeting, does not support the translated fields:
• Adding agenda Item, does not support translated fields
• Meeting questionnaire (Manage poll) is not styled:
• The answer options fields does not support translated fields
• Survey, adding answers does not support translated fields:
• Edit debate fields, are not properly formatted:
• Elections Add images is not properly marked as button:
• Debates Conclusion WYSIWYG field in Close debate form does not respect the Look & feel:
• Budgets ( edit form) - scope is not properly formatted
• Budgets ( edit form) - description is not properly formatted (spacing)
• Budgets - Send Voting reminders is missing some padding.
• Edit images in edit project form is not properly marked as button:
• Budgets -> Navigation is displaying the special chars.
• Attachments edit form is not properly formatted
• The tooltip on Filtes is strange
• The space is displaying the "new" action on the gray bar, but the component related actions are displayed as buttons in the page. Admin buttons placement #11583
• Import results is missing some padding
• Wrong asset paths
• Hardcoded components box present only in Participatory Process
• Wrong breadcrumb element order Redesign: Import proposals from file displays wrong breadcrumb order #11621
• Unused code
• Unused code
• Per Page selector
• Commented code
• Commented code

[alecslupu]

The following commits needs to be cherry picked:

#11144
e9ca27b
ed52534
b6c1bd4
d7a8492
5161cfe
ca730ce
388f823
7a1d03e
79a9914
a1e7bab
a7d76fd
c7f1b63
01e0ee1
01f5e68
46976f1
d94fcad
b79215e
fa9e0e3
ace8609
31d9f8c
95dbd4f
2c84460
e60ae2b
d1e157e
c33474b
a58cb7b
79fca2f
f450bb6
a4a4435
bf918a8
21a27e4
2b5a68d
9d791d5
2c2b88d
52a127a
5457875
29d2450
426dfc5
2598f62
aab2c77
87bdc6c
f78a24b
ad3c89b
550e0b5
330d17d
01b97f0
215b983
084316e
c6c31a4
5cb9717

[ferblape]

@decidim/product notice the url is different, but all the credentials are the same (we duplicated the staging database 2 weeks ago).

[alecslupu]

This PR has become way to big, considering what we previously agreed, however browsing through it i could find some structural issues, or at least this is my first impression.

1a. In the process, we have 2 tabs one for Processes and one for Process groups, action for each one of the sections being collapsed in right "..." menu (including Process types, which can reside in its own tab entry)
1b. In the assemblies, we have no tabs. The assembly types are missing completely (even though the page is redesigned)
1c. In the initiatives, we have no tabs. The "..." is hiding "initiatives", "Initiative types" and "Settings"

2. Global moderation there should be 2 tabs ( there are 2 entries now hidden in "..." menu)

My first impression after seeing the admin interface, is that some of the elements are not placed in a visible space, making hard for a new comer to easily understand the Decidim.

Here is a list of things that i had to do:

1. Open the admin
2. click Processes
3. Click a participatory space (At this point i already see the components in the right with published state)
4. From the "..." Menu i could see Components
5. Clicking there I could see add component
6. On where i could add a new Component.

On the Participatory processes, i could see that navigating to:

• The Process i had a right toolbar containing components,
• the "About process" i have a left sidebar

Some other unstructured feedback:

1. The width of the admin is not full screen: ( the .title-bar has a width of about 1800px, but the container is just 1500px, resulting a 250 - 300px bar in the right)
2. Is we are using the Tabbing concept, then the process Attachments could be added as a single menu entry that would then lead to a tabbed view
3. In the Process before "Actividad reciente" we could add some kind of cell lock that would allow us to add some common activities "Moderate content", "Add a new component" etc
4. There is no visual confirmation on permissions being applied (in 0.27 we would have the key turning yellow if there were permissions assigned)
5. Some of the forms, do not have the desired look and feel even though they have been touched. ( edit meeting for example )
6. The Language drop down + validation is too packed together

Attachments

Meeting form

Length + Language

[Crashillo]

Finally, specs are passing and all comments has been fixed or addressed 🎉

[alecslupu]

There is a lot of work added to this PR, and during the Review we have found several design / code issues regarding the implementation. As a result, during our common meetings, we have decided to split the work in sub tasks that can be done at a later stage, by various individuals so that we respect the time and budgets constraints:

Also, due to setup difficulties, the elections / votings module has not been properly reviewed.
Overall review progress at approval time is 95.4% (782 / 819 files viewed)

The list of tasks:

• Admin Participatory Process Issues #11635
• Admin pages Issues #11634
• Admin meetings Issues #11633
• Admin issues in Initiatives #11632
• Admin proposals Issues #11609
• Admin elections Issues #11608
• Admin sortitions Issues #11607
• Admin templates Issues #11606
• Admin debates Issues #11605
• Admin verifications Issues #11604
• Admin conferences Issues  #11603
• Admin budgets Issues #11602
• Admin blogs Issues #11601
• Assemblies Admin module Issues #11600
• Admin module Issues #11596
• Admin accountability Issues #11593
• Admin buttons placement #11583
• Redesign: Import proposals from file displays wrong breadcrumb order #11621

Types of issues that we will touch at a later stage are mostly design & product related:

• Extra parameters passed to form objects ( titles )
• Duplicate page titles ( as part of the page & part of the card )
• Wrongly placed buttons ( ex Buttons placed under the title bar in 2 files )
• Missing styles on forms
• Missing or Unneeded sidebars
• Extra parameters passed to pagination

As result of all of the above this PR is

APPROVED

Dismissing the review. As agreed, will be tackled by maintainers or redesign team, at a later date, starting from the example provided by redesign team.