Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 'Fix password confirm validation error message' to v0.26 #11934

Conversation

andreslucena
Copy link
Member

🎩 What? Why?

Backport #11625 to v0.26

♥️ Thank you!

* Password confirm validation

* changes to password confirm message

* pushing whats been changed

* updated changes to add quotes to error message on pw

* normalisation of i18n strings in locales

* Update decidim-core/spec/forms/account_form_spec.rb

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

* Added test in registeration_form_spec and change in flash.now[:alert] registrations controller

* test failure changes

* Fixing of SPEC failures

* rspec tests fix

* test

* Broken test with Catalan translation  for sign-in fix

* Registration form spec fix

* fixes to rspec registerations controller on flash message

* Update decidim-core/config/locales/ca.yml

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

---------

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
@andreslucena andreslucena added module: core backport Pull Requests that are a backport for a fixed bug type: fix PRs that implement a fix for a bug labels Nov 3, 2023
Copy link
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alecslupu alecslupu added this to the 0.26.9 milestone Nov 3, 2023
@alecslupu alecslupu merged commit a1aa5d5 into release/0.26-stable Nov 3, 2023
48 checks passed
@alecslupu alecslupu deleted the backport/0.26/fix/confirm-password-validation-11625 branch November 3, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Pull Requests that are a backport for a fixed bug module: core type: fix PRs that implement a fix for a bug
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants