Fix filter by scope on search page

[fblupi]

🎩 What? Why?

Fix the error raised when filtering by scope on the search page. The scope filter has been removed on the redesign, that's why this PR targets the release/0.27-stable branch instead of develop.

This error raises because we are using the ransack _eq filter instead of the _in using an array as input. In the front end, we use the scopes_picker_filter helper to render the scope multi-picker, and it produces an array argument instead of a single value. That's why I have changed the ransack filter in this PR.

IMO, we should remove the references to the scope filter in the search controller and command in the develop branch, as we are no longer using it since the redesign was merged.

📌 Related Issues

• Fixes Unable to filter by scope on search page #12023

Testing

1. Go to the search bar and find by text
2. Scroll down and filter by scope
3. See it filters by scope

📷 Screenshots

Screen.Recording.2023-11-20.at.12.29.00.mov

♥️ Thank you!

[andreslucena]

IMO, we should remove the references to the scope filter in the search controller and command in the develop branch, as we are no longer using it since the redesign was merged.

I'm not 100% sure that this was indeed a decision made by @decidim/product or just limitations in the redesign development bandwith (or just an oversights). @decidim/product do you want to drop this feature ("filtering by scopes /search")? Or is it better to just remove the dead code?

[andreslucena]

Tried it out locally and it works as expected. Can you also add a system spec that would have detected this bug? Thanks

[andreslucena]

👍🏽

[andreslucena]

Adding the no-backport label as this change isn't relevant for v0.26: this was introduced by the big ransack change of v0.27. (Let me know if you think that that's not the case @fblupi)

[andreslucena]

Only failing check is codecov, so I'm merging this

[fblupi]

Adding the no-backport label as this change isn't relevant for v0.26: this was introduced by the big ransack change of v0.27. (Let me know if you think that that's not the case @fblupi)

That's right. This error appeared with the searchlight to ransack migration.

[andreslucena]

IMO, we should remove the references to the scope filter in the search controller and command in the develop branch, as we are no longer using it since the redesign was merged.

I'm not 100% sure that this was indeed a decision made by @decidim/product or just limitations in the redesign development bandwith (or just an oversights). @decidim/product do you want to drop this feature ("filtering by scopes /search")? Or is it better to just remove the dead code?

@fblupi we've discussed in the last @decidim/product and we agreed that for the time being this should be removed as we're not planning in introducing that back. Can you do the PR 🙏🏽 ? I don't find the references to scopes in search related classes, so you have more in your head what needs to be changed exactly. Thanks!!

[fblupi]

@andreslucena I did the PR at the same time I did this one, and it was already approved and merged by @alecslupu here: #12038