Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused scope filter from search controller and command #12038

Merged
merged 1 commit into from Nov 20, 2023

Conversation

fblupi
Copy link
Member

@fblupi fblupi commented Nov 20, 2023

馃帺 What? Why?

As mentioned in the related issue (with the redesign already merged) we no longer filter by scope on the search page. In this PR I remove the unused code.

馃搶 Related Issues

鈾ワ笍 Thank you!

@fblupi fblupi added module: core type: removal PRs that implement a removal of a functionality or code labels Nov 20, 2023
@fblupi fblupi requested a review from a team November 20, 2023 13:32
Copy link
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃挴

@alecslupu alecslupu merged commit 8f8ae99 into develop Nov 20, 2023
106 of 107 checks passed
@alecslupu alecslupu deleted the chore/12023 branch November 20, 2023 19:46
@fblupi fblupi added the no-backport Pull Requests that should not be backported label Nov 21, 2023
entantoencuanto added a commit that referenced this pull request Nov 27, 2023
* develop: (51 commits)
  Fix a11y violations and title layout on announcements (#12067)
  Fix randomness on nickname and emails for seeded users (#12058)
  Fix render partial deprecation warning on proposals (#12035)
  Redesign: proposal counter total number avaliable (#12014)
  Fix disabling access to space private users when the space is public (#12031)
  Redesign: admin screen overflow on smaller screens (#11956)
  Make the breadcrumb consistent in the components import pages (#12024)
  Fix develop branch (#12051)
  Create the IconRegistry (#11982)
  Fix process groups component content blocks (#11872)
  Remove the asemblies settings page (#11873)
  Fix n+1 query on assemblies permissions (#12040)
  Remove unused scope filter from search controller and command (#12038)
  Fix issues in "Verify your identity" (#12030)
  Fix flash of dropdowns in buttons from the title bar and "Manage" button (#12011)
  Add CI workflow configuration for decidim-design (#12022)
  Extract methods from participatory processes seeds (#12032)
  Show message when there are no debates (#12037)
  Show error message when there are no budgets nor projects in budgets (#12034)
  Fix faker requirement in production environment 2 (#12033)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: core no-backport Pull Requests that should not be backported type: removal PRs that implement a removal of a functionality or code
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants