Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated chromedriver setting in v0.27 #12182

Merged
merged 1 commit into from Dec 18, 2023

Conversation

alecslupu
Copy link
Contributor

@alecslupu alecslupu commented Dec 17, 2023

🎩 What? Why?

Back in #12162, we have back ported a ChromeDriver lock to 0.27. Unfortunately, we have not taken into account the old setting. So when we merged #12050, all the pipelines started to fail.

📌 Related Issues

Link your PR to an issue

Testing

Make sure the pipeline is green.

♥️ Thank you!

@alecslupu alecslupu added this to the 0.27.5 milestone Dec 17, 2023
@alecslupu alecslupu requested a review from a team December 17, 2023 18:28
@alecslupu alecslupu marked this pull request as ready for review December 17, 2023 18:28
@andreslucena andreslucena changed the title Update chromedriver settings Remove duplicated chromedriver setting in GH action configuration Dec 18, 2023
Copy link
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uops missed that one, nice catch!

@andreslucena andreslucena changed the title Remove duplicated chromedriver setting in GH action configuration Remove duplicated chromedriver setting in v0.27 Dec 18, 2023
@andreslucena andreslucena added type: fix PRs that implement a fix for a bug release: v0.27 Issues or PRs that need to be tackled for v0.27 labels Dec 18, 2023
@andreslucena andreslucena merged commit 5e5d5e3 into release/0.27-stable Dec 18, 2023
49 checks passed
@andreslucena andreslucena deleted the chore/fix-027-pipeline branch December 18, 2023 07:35
@andreslucena andreslucena added the no-backport Pull Requests that should not be backported label Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport Pull Requests that should not be backported release: v0.27 Issues or PRs that need to be tackled for v0.27 type: fix PRs that implement a fix for a bug
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants