Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated chromedriver setting in v0.26 #12186

Merged
merged 1 commit into from Dec 18, 2023

Conversation

andreslucena
Copy link
Member

🎩 What? Why?

As in #12182:

Back in #12162, we have back ported a ChromeDriver lock to 0.27. Unfortunately, we have not taken into account the old setting. So when we merged #12050, all the pipelines started to fail.

This PR brings that same change to v0.26

📌 Related Issues

Related to #12162

Testing

Make sure the pipeline is green.

♥️ Thank you!

@andreslucena andreslucena added type: fix PRs that implement a fix for a bug release: v0.26 Issues or PRs that need to be tackled for v0.26 labels Dec 18, 2023
Copy link
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alecslupu alecslupu added this to the 0.26.9 milestone Dec 18, 2023
@alecslupu alecslupu self-assigned this Dec 18, 2023
@alecslupu alecslupu merged commit f74cd34 into release/0.26-stable Dec 18, 2023
48 checks passed
@alecslupu alecslupu deleted the chore/fix-026-pipeline branch December 18, 2023 11:05
@andreslucena andreslucena added the no-backport Pull Requests that should not be backported label Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport Pull Requests that should not be backported release: v0.26 Issues or PRs that need to be tackled for v0.26 type: fix PRs that implement a fix for a bug
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants