New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport 'Patch participatory spaces factories' to v0.27 #12647
Backport 'Patch participatory spaces factories' to v0.27 #12647
Conversation
* Patch ParticipatoryProcess factories * Use correct factories * Fix decidim participatory process output * Fix more specs * Fix more specs * Last spec? * Apply suggestions from code review Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> --------- Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
6d238a1
to
1f81d75
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a couple of suggestions and a doubt regarding the current approach for the backports, can you check them out please?
decidim-blogs/spec/events/decidim/blogs/create_post_event_spec.rb
Outdated
Show resolved
Hide resolved
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Second round, can you check my feedback please?
decidim-core/spec/presenters/decidim/push_notification_presenter_spec.rb
Show resolved
Hide resolved
decidim-meetings/app/helpers/decidim/meetings/directory/application_helper.rb
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this as the pending conversations were moved to other issues or PRs and I don't want to block
🎩 What? Why?
Backport #12341 to v0.27