Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 'Patch participatory spaces factories' to v0.27 #12647

Conversation

alecslupu
Copy link
Contributor

🎩 What? Why?

Backport #12341 to v0.27

♥️ Thank you!

* Patch ParticipatoryProcess factories

* Use correct factories

* Fix decidim participatory process output

* Fix more specs

* Fix more specs

* Last spec?

* Apply suggestions from code review

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

---------

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
@alecslupu alecslupu added backport Pull Requests that are a backport for a fixed bug type: fix PRs that implement a fix for a bug type: internal PRs that aren't necessary to add to the CHANGELOG for implementers labels Mar 24, 2024
@alecslupu alecslupu force-pushed the backport/0.27/patch-participatory-spaces-fac-12341 branch from 6d238a1 to 1f81d75 Compare March 24, 2024 21:13
Copy link
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a couple of suggestions and a doubt regarding the current approach for the backports, can you check them out please?

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
Copy link
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second round, can you check my feedback please?

Copy link
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this as the pending conversations were moved to other issues or PRs and I don't want to block

@andreslucena andreslucena merged commit e1e6aa6 into release/0.27-stable Apr 5, 2024
42 checks passed
@andreslucena andreslucena deleted the backport/0.27/patch-participatory-spaces-fac-12341 branch April 5, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Pull Requests that are a backport for a fixed bug type: fix PRs that implement a fix for a bug type: internal PRs that aren't necessary to add to the CHANGELOG for implementers
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants