Backport 'Patch events on the new format' to v0.27 #12648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Patch ParticipatoryProcess factories * Use correct factories * Fix decidim participatory process output * Fix more specs * Fix more specs * Last spec? * Apply suggestions from code review Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> --------- Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
* Patch events on the new format * Some refactor * Fix more specs * Fix specs * Running linters * Patch the specs * RUnning linters * Fix admin spec * Fixing more specs * patch test * Apply review recommendations * Fix failing specs * Fix failing specs on conferences * Update decidim-core/spec/lib/events/simple_event_spec.rb Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> --------- Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
alecslupu
added
backport
|
depends on #12647 |
…github.com:decidim/decidim into backport/0.27/patch-events-on-the-new-format-12345
alecslupu
changed the base branch from
release/0.27-stable
to
backport/0.27/patch-participatory-spaces-fac-12341
This was referenced Apr 2, 2024
Base automatically changed from
backport/0.27/patch-participatory-spaces-fac-12341
to
release/0.27-stable
April 5, 2024 13:09
… backport/0.27/patch-events-on-the-new-format-12345
andreslucena
requested changes
Apr 8, 2024
There was a problem hiding this comment.
Missing change from:
decidim-core/lib/decidim/events/base_event.rbdecidim-admin/spec/events/decidim/component_published_event_spec.rbdecidim-participatory_processes/spec/events/decidim/participatory_process_role_assigned_event_spec.rbdecidim-participatory_processes/spec/events/decidim/participatory_process_step_activated_event_spec.rbdecidim-participatory_processes/spec/events/decidim/participatory_process_step_changed_event_spec.rb
(These three were there, but not in the same order as I was expecting them, sorry for the noise)
decidim-admin/spec/events/decidim/attachment_created_event_spec.rb
Outdated
Show resolved
Hide resolved
decidim-blogs/spec/events/decidim/blogs/create_post_event_spec.rb
Outdated
Show resolved
Hide resolved
decidim-blogs/spec/events/decidim/blogs/create_post_event_spec.rb
Outdated
Show resolved
Hide resolved
decidim-initiatives/spec/events/decidim/initiatives/spawn_committee_request_event_spec.rb
Outdated
Show resolved
Hide resolved
decidim-initiatives/spec/events/decidim/initiatives/revoke_membership_request_event_spec.rb
Outdated
Show resolved
Hide resolved
...atives/spec/events/decidim/initiatives/initiative_sent_to_technical_validation_event_spec.rb
Show resolved
Hide resolved
andreslucena
requested changes
Apr 8, 2024
.../spec/events/decidim/initiatives/admin/initiative_sent_to_technical_validation_event_spec.rb
Show resolved
Hide resolved
...im-initiatives/spec/events/decidim/initiatives/admin/support_threshold_reached_event_spec.rb
Show resolved
Hide resolved
...participatory_processes/spec/events/decidim/participatory_process_step_changed_event_spec.rb
Show resolved
Hide resolved
Thank you for your review:
|
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
|
@andreslucena , i have tried to apply your suggestions, but some of them did not get through as it crashed the pipeline. |
andreslucena
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
I think there are some changes from #12338 here, but I don't want to block you so we can keep backporting the pending PRs to v0.27.
andreslucena
deleted the
backport/0.27/patch-events-on-the-new-format-12345
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Backport #12345 to v0.27