-
-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove sidebar when conference has no components #12849
Remove sidebar when conference has no components #12849
Conversation
It seems like you did not give us much information about what you are trying to do here. We would appreciate it if you could provide us with more info about this issue/PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request does not contain a valid label. Please add one of the following labels: ['type: feature', 'type: change', 'type: fix', 'type: removal', 'target: developer-experience', 'type: internal']
@carolromero should we show no sidebar (as in the screenshot) or empty sidebar (without the empty purple box of course)? |
@andreslucena better not to show the sidebar as @ElviaBth suggests in the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried it locally, and it works as expected, also the tests are perfect! 馃憦馃徑 馃憦馃徑
I'd like to change the tertiary operator to give it a variable and not have too much noise in the same line. It's just a stylistic thing.
decidim-conferences/app/views/decidim/conferences/conferences/show.html.erb
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
馃憤馃徑
馃帺 What? Why?
Although there is nothing in the submenu of the participatory space, the sidebar appears.
Nothing should be displayed if there is no sub-menu section.
To fix this a conditional render was added so if there are any conference_nav_items, then layout_two_col will be displayed in another case layout_center.
馃搶 Related Issues
Testing
馃摲 Screenshots
before
after