Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sidebar when conference has no components #12849

Merged

Conversation

ElviaBth
Copy link
Contributor

@ElviaBth ElviaBth commented May 15, 2024

馃帺 What? Why?

Although there is nothing in the submenu of the participatory space, the sidebar appears.
Nothing should be displayed if there is no sub-menu section.

To fix this a conditional render was added so if there are any conference_nav_items, then layout_two_col will be displayed in another case layout_center.

馃搶 Related Issues

  • Related to #
  • Fixes #?

Testing

  • Go to Decidim
  • Sign in at http://localhost:3000
  • Visit conferences
  • Create a new conference(don't add any component) and publish.
  • See the site, there is an empty sidebar.

馃摲 Screenshots

before
image

after
image

鈾ワ笍 Thank you!

Copy link

request-info bot commented May 15, 2024

It seems like you did not give us much information about what you are trying to do here. We would appreciate it if you could provide us with more info about this issue/PR!

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['type: feature', 'type: change', 'type: fix', 'type: removal', 'target: developer-experience', 'type: internal']

@microstudi microstudi added the type: fix PRs that implement a fix for a bug label May 15, 2024
github-actions[bot]
github-actions bot previously approved these changes May 15, 2024
github-actions[bot]
github-actions bot previously approved these changes May 15, 2024
@ElviaBth ElviaBth marked this pull request as ready for review May 15, 2024 14:51
github-actions[bot]
github-actions bot previously approved these changes May 15, 2024
@andreslucena andreslucena self-assigned this May 16, 2024
@andreslucena
Copy link
Member

@carolromero should we show no sidebar (as in the screenshot) or empty sidebar (without the empty purple box of course)?

github-actions[bot]
github-actions bot previously approved these changes May 16, 2024
github-actions[bot]
github-actions bot previously approved these changes May 16, 2024
@carolromero
Copy link
Member

@andreslucena better not to show the sidebar as @ElviaBth suggests in the PR.

Copy link
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it locally, and it works as expected, also the tests are perfect! 馃憦馃徑 馃憦馃徑

I'd like to change the tertiary operator to give it a variable and not have too much noise in the same line. It's just a stylistic thing.

Copy link
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤馃徑

@andreslucena andreslucena merged commit 8afa643 into decidim:develop May 16, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: conferences type: fix PRs that implement a fix for a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants