Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix organization multitenant issue with meeting's reminders #12671

Merged
merged 2 commits into from
May 6, 2024

Conversation

alecslupu
Copy link
Contributor

@alecslupu alecslupu commented Apr 5, 2024

🎩 What? Why?

This PR fixes a scenario where CloseMeetingReminder is sending Meeting Reminders to any admin user in any organization.

📌 Related Issues

Link your PR to an issue

Testing

  1. Create 2 organizations inside a single installation
  2. Invite admins
  3. In one organziation create an official meeting
  4. Allow the event to end ( or set the end date in the past )
  5. Send the reminders
  6. See both admin users receives the notification
  7. Apply patch
  8. Repeat 3,4,5
  9. See only the organization admin in which the meeting has been created receives the notification.

📷 Screenshots

Please add screenshots of the changes you are proposing
Description

♥️ Thank you!

@alecslupu alecslupu added the type: fix PRs that implement a fix for a bug label Apr 5, 2024
@alecslupu alecslupu linked an issue Apr 5, 2024 that may be closed by this pull request
@andreslucena
Copy link
Member

@alecslupu can you fill the templates? FYI, I receive an email notification that doesn't bring much information:

Screenshot of the email notification generated by this PR

@alecslupu alecslupu changed the title Fix organization tennancy issue Fix organization multitenant issue Apr 5, 2024
@alecslupu alecslupu marked this pull request as ready for review April 5, 2024 15:58
@alecslupu alecslupu requested a review from a team April 5, 2024 15:58
@andreslucena andreslucena changed the title Fix organization multitenant issue Fix organization multitenant issue with meeting's reminders Apr 15, 2024
Copy link
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked it out locally. It works as expected, and code-wise looks great!

@microstudi
Copy link
Contributor

@andreslucena is this going to be backported to 0.27?

@andreslucena
Copy link
Member

@andreslucena is this going to be backported to 0.27?

Yes, FYI, this is the current set of backports in the backlog:

ID Title Backport v0.28 Backport v0.27
#12880 Fix external URL with a fragment None None
#12877 Remove unecessary accordion in Conferences' program None None
#12875 Add proposal author when exporting proposals None None
#12864 Fix exception when going to debates new URL directly as non-logged user None None
#12858 Prevent showing the dropdown menu when changing orientation of mobile devices None None
#12857 Fix strings for ordering when listing budgets None None
#12849 Remove sidebar when conference has no components #12863 None
#12847 Fix 500 error when creating or updating an organization without a secret key #12862 None
#12843 Fix exceptions there isn't an organization with a host #12861 None
#12837 Add organization or application name in emails' From header #12860 None
#12829 Hide moderated content from notifications None None
#12827 Add the rel="nofollow noopener noreferrer" attribute to external links #12832 None
#12746 Fix several HTML validation issues in redesign #12859 None
#12709 Fix admin language selector #12855 None
#12706 Fix broken conference registering when no registration types #12833 None
#12689 Fix layout in Safari when there are few elements in the page #12854 None
#12682 Show meeting timezone for visitors and participants #12787 None
#12671 Fix organization multitenant issue with meeting's reminders #12838 None
#12636 Fix flaky with accessibility errors in Direct Uploads #12756 None
#12587 Fix impersonnating users #12740 None
#12550 Fix newsletter flow in admin panel #12606 None
#12538 Do not list hidden reported debates in the admin #12607 None
#12530 Review brakeman configuration #12609 None
#12529 Improve iframe accessibility #12748 None
#12517 Accessibility fixes regarding links that open in new tabs #12739 None
#12513 Fix some accessibility issues with comments #12834 None
#12324 Fix a11y "page-has-heading-one" warning for some pages in the admin panel #12429 None

(The ones that have None will be backported if they're relevant to that version)

This is done with an internal tool (decidim-backports-checker from https://github.com/decidim/decidim-maintainers_toolbox/)

I'll handle this particular backport this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: meetings type: fix PRs that implement a fix for a bug
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Admin notifications cross instances
3 participants