Rename system command names for consistency #12852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greenwoodt
added
module: core
module: pages
module: system
type: change
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
andreslucena
changed the title
andreslucena
requested changes
May 17, 2024
decidim-system/spec/commands/decidim/system/register_organization_spec.rb
Outdated
Show resolved
Hide resolved
|
@greenwoodt can you check the git conflict? you need to resolve it with the command line |
…decidim into fix/rename-page-seed-command
Rebased the branch with Develop and seemed to solve the issue with the CI. Feel free to review. |
|
@greenwoodt we have conflicts again, sorry :( I will stop merging until we finish this one. |
andreslucena
requested changes
May 23, 2024
There was a problem hiding this comment.
Heads up! There was a bad merge related to #12286
We need to leave the organization name translatable. Can you check it out please? I think with my suggestions should be enough
decidim-system/app/commands/decidim/system/create_default_help_pages.rb
Outdated
Show resolved
Hide resolved
decidim-system/app/commands/decidim/system/create_default_help_pages.rb
Outdated
Show resolved
Hide resolved
decidim-system/app/commands/decidim/system/create_default_help_pages.rb
Outdated
Show resolved
Hide resolved
decidim-system/app/commands/decidim/system/create_default_help_pages.rb
Outdated
Show resolved
Hide resolved
decidim-system/app/commands/decidim/system/create_default_help_pages.rb
Outdated
Show resolved
Hide resolved
…_pages.rb Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
…_pages.rb Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
…_pages.rb Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
…_pages.rb Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
…_pages.rb Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
…_pages.rb Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
decidim-system/app/commands/decidim/system/create_default_help_pages.rb
Outdated
Show resolved
Hide resolved
decidim-system/app/commands/decidim/system/create_default_help_pages.rb
Outdated
Show resolved
Hide resolved
No worries! |
…_pages.rb Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
…_pages.rb Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
andreslucena
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
While working on footer revamp in #12592 I noticed it was quite difficult to find the Page & Topic commands which seeded the DB. To provide more clarity in the future on the location of commands which seed the DB in relation to the creation of this feature/module, we have renamed them and certain calls such as
RegisterOrganisationaccordingly.📌 Related Issues
populate_help.rbtostatic_pages_seeds.rb#12842Testing
Find the following file paths in your installation
decidim-system/app/commands/decidim/system/create_default_help_pages.rb+decidim-system/app/commands/decidim/system/create_organization.rb📷 Screenshots