Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix strings for ordering when listing budgets #12857

Merged
merged 1 commit into from
May 21, 2024
Merged

Fix strings for ordering when listing budgets #12857

merged 1 commit into from
May 21, 2024

Conversation

andreslucena
Copy link
Member

馃帺 What? Why?

While checking out #11000, I found a mini-bug in the strings: if you go to a budget component with multiple components, instead of saying "Order budgets by" it says "Order projects by".

This PR fixes it.

馃搶 Related Issues

Testing

  1. Go to a process with multiple budgets in a mobile view
  2. See the string for ordering the budgets

馃摲 Screenshots

Before

Screenshot of the wrong string

After

Screenshot of the fixed string

鈾ワ笍 Thank you!

@andreslucena andreslucena added the type: fix PRs that implement a fix for a bug label May 17, 2024
alecslupu
alecslupu approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤

@alecslupu alecslupu merged commit c9ddbb4 into develop May 21, 2024
48 of 49 checks passed
@alecslupu alecslupu deleted the fix/budgets-filters-strings branch May 21, 2024 19:26
This was referenced May 28, 2024
Merged
Merged
@ElviaBth ElviaBth mentioned this pull request Jun 4, 2024
Draft
@andreslucena
Copy link
Member Author

Adding the no-backport label as this order feature was introduced in v0.28 with the redesign and it was already merged to that version

@andreslucena andreslucena added the no-backport Pull Requests that should not be backported label Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecslupu alecslupu alecslupu approved these changes

@github-actions github-actions[bot] github-actions approved these changes

Assignees

@alecslupu alecslupu

Labels
module: budgets no-backport Pull Requests that should not be backported type: fix PRs that implement a fix for a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andreslucena @alecslupu