Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception when going to debates new URL directly as non-logged user #12864

Merged
merged 2 commits into from
May 27, 2024

Conversation

andreslucena
Copy link
Member

🎩 What? Why?

There's an exception when visiting a new debates form page directly as a visitor. This PR fixes it.

I've also added some specs for this same problem in components with the "Participants can create ..." setting: Proposals and Meetings.

📌 Related Issues

Testing

  1. Sign in as admin
  2. Enable debates created by participant in a debates component in a participatory space
  3. Go to the debates index page
  4. Click in the "New debate" button
  5. Copy the URL
  6. Open it in a new incognito/private session in your browser
  7. (Without the patch) see an exception
  8. (With the patch) see that you're redirected to the login page

♥️ Thank you!

@andreslucena andreslucena changed the title Fix exception when going to debates new URL directly as non-logged user Fix exception when going to debates new URL directly as non-logged user May 21, 2024
Copy link
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix works as expected, but i would change a spec to respect the consistency with the rest of the specs added within this PR.

@andreslucena
Copy link
Member Author

The fix works as expected, but i would change a spec to respect the consistency with the rest of the specs added within this PR.

As we've talked currently the three specs are controller specs so they're consistent in that aspect. Maybe can you give it another look 😄 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants