-
-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the flaky seeds for comments #13013
Open
andreslucena
wants to merge
1
commit into
develop
Choose a base branch
from
fix/comments-seeds
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I could reproduce this bug on my local machine. Using this branch. To reproduce:
|
Can you provide the full traceback 馃檹馃徑 ? To see in exactly which method is it failing. Thanks! |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃帺 What? Why?
We have some flaky seeds in comments, where sometimes you run the
db:seeds
command and it fails.I think it's related to making the query for Users wrongly, as we need to add the usual scopes (i.e. confirmed, not deleted, not moderated).
This PR fixes it. I also added a small refactor for the method names to better reflect what they do.
Testing
bin/rails db:drop db:create db:migrate assets:precompile db:seed
and see that it doesn't fails a couple of timesStacktrace
These were the exceptions that I saw:
create_votes
methodcreate_comment
method