Fix the flaky seeds for comments

decidim-comments/app/models/decidim/comments/seed.rb

@@ -31,9 +31,8 @@ def comments_for(resource)
 
             next if [true, false].sample
 
-            [comment1, comment2].compact.each do |comment|
-              create_votes(comment)
-            end
+            create_votes(comment1) if comment1
+            create_votes(comment2) if comment2
           end
         end
 
@@ -50,8 +49,8 @@ def comments_for(resource)
         #
         # @return [Decidim::Comments::Comment]
         def create_comment(resource, root_commentable = nil)
-          author = user
-          user_group = user_group(author)
+          author = random_user
+          user_group = random_user_group(author)
 
           params = {
             commentable: resource,
@@ -79,25 +78,30 @@ def create_comment(resource, root_commentable = nil)
         # @return nil
         def create_votes(comment)
           rand(0..12).times do
-            author = user
-            user_group = user_group(author)
-
-            CommentVote.find_or_create_by(
-              comment:,
-              author: [author, user_group].compact.sample,
-              weight: [1, -1].sample
-            )
+            user = random_user
+            user_group = random_user_group(user)
+            author = [user, user_group].compact.sample
+            next if CommentVote.where(comment:, author:).any?
+
+            CommentVote.create!(comment:, author:, weight: [1, -1].sample)
           end
 
           nil
+        rescue ActiveRecord::AssociationTypeMismatch
+          nil # in case there is a mismatch, we ignore the error as it is not important for the seeding
         end
 
-        def user
-          Decidim::User.where(organization:).all.sample
+        def random_user
+          user = Decidim::User.where(organization:).not_deleted.not_blocked.confirmed.sample
+
+          user.valid? ? user : random_user
         end
 
-        def user_group(user)
-          [true, false].sample ? Decidim::UserGroups::ManageableUserGroups.for(user).verified.sample : nil
+        def random_user_group(user)
+          user_group = Decidim::UserGroups::ManageableUserGroups.for(user).verified.sample
+          return nil unless user_group&.valid?
+
+          [true, false].sample ? user_group : nil
         end
       end
     end