Add attachments to proposals

[beagleknight]

🎩 What? Why?

This adds attachments to proposals both for official and not official ones. As a user I will be able to upload a single attachment to a proposal. Uploads can be images or pdfs.

📌 Related Issues

• Closes Attachments to proposals #1029
• Related to Add images to official proposals  #1252

📋 Subtasks

• Feature spec
• User can upload attachments when creating a proposal
• Admin can upload attachments when creating a proposal
• Update CHANGELOG
• Remove checkbox and add text instead

📷 Screenshots (optional)

👻 GIF

[codecov]

Codecov Report

Merging #1688 into master will decrease coverage by 0.01%.
The diff coverage is 96.45%.

@@            Coverage Diff             @@
##           master    #1688      +/-   ##
==========================================
- Coverage   98.59%   98.58%   -0.02%     
==========================================
  Files         966      968       +2     
  Lines       22029    22163     +134     
==========================================
+ Hits        21720    21849     +129     
- Misses        309      314       +5

[josepjaume]

Should we maybe put uploads under a global setting flag? It might be surprising for existing processes to suddenly see uploads enabled.

[josepjaume]

Why do we have "attachment terms"?

[josepjaume]

(And where do we customize that?)

[josepjaume]

Also, the catalan translation of "crear proposta" seems to be wrong, it should be "autor de la proposta", but that's outside of the scope of this PR.

[mention-bot]

@beagleknight, thanks for your PR! By analyzing the history of the files in this pull request, we identified @oriolgual and @divins to be potential reviewers.

[beagleknight]

@josepjaume It is already a global setting 😅

[beagleknight]

@josepjaume argh.. I can't answer your comments individually...

Why do we have "attachment terms"?

@oriolgual suggested this checkbox to warn the users to upload safe content, etc. I am not sure what copy may I use 😄

(And where do we customize that?)

It could be a setting as well... but then we need i18n for feature settings (I am already working on it in another branch, not published yet).

Also, the catalan translation of "crear proposta" seems to be wrong, it should be "autor de la proposta", but that's outside of the scope of this PR.

Yeah, I saw it 😄 . We need to do a revision of public forms copys.

[josepjaume]

@beagleknight as for the attachment terms, I would just put an explanation there that's hard-coded into the app. No need to customize that nor to have a checkbox.

Thoughts @oriolgual?

[oriolgual]

Seems OK for me, the problem is that I'm not sure what those terms should be :/ @josepjaume @beagleknight

[beagleknight]

@josepjaume @oriolgual I can remove the checkbox and add the text you mentioned as soon as we have it 😄

[josepjaume]

I would merge this and add the text on a further PR @beagleknight . Thoughts @oriolgual ?

[josepjaume]

We need to add hints and support text everywhere sometime soon anyway.

[beagleknight]

@josepjaume I agree but... should we remove the checkbox then?

[josepjaume]

@beagleknight yeah, I would remove it 👍