-
-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show a disabled follow button to anonymous users #1903
Conversation
302e0b7
to
720d45e
Compare
Codecov Report
@@ Coverage Diff @@
## master #1903 +/- ##
=======================================
Coverage 98.48% 98.48%
=======================================
Files 1127 1127
Lines 25326 25326
=======================================
Hits 24943 24943
Misses 383 383 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super nice!
Why don't we do like voting button when not authorized/verified... The button is shown and when you click you are promoted to register/verify. I think this is a perfect onboarding strategy. |
@xabier looks like a nice idea. At the moment this was the quickest solution, but we can definitely improve this, as well as lots of other call to actions that could prompt the user to register. |
@josepjaume A disabled button is disencouraging and disempowering, a clickable button is ... clickable! then I click and I am asked to proceed to sign-in/up, lets keep this in mind! if this is a quick fix is fine. |
🎩 What? Why?
When an anonymous user (lot logged in) visits a followable resource, we didn't show any "Follow" button. This PR adds a disabled "Follow" button so the user cannot click it, but knows that the action can be performed. It also shows a tooltip prompting the user to sign in before following.
📌 Related Issues
📋 Subtasks
None
📷 Screenshots (optional)