Show a disabled follow button to anonymous users #1903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrcasals
force-pushed
the
disable-voting-tooltip-anonymous-users
branch
from
302e0b7
to
720d45e
Compare
Codecov Report
@@ Coverage Diff @@
## master #1903 +/- ##
=======================================
Coverage 98.48% 98.48%
=======================================
Files 1127 1127
Lines 25326 25326
=======================================
Hits 24943 24943
Misses 383 383 |
beagleknight
approved these changes
Sep 21, 2017
ghost
removed
the
|
Why don't we do like voting button when not authorized/verified... The button is shown and when you click you are promoted to register/verify. I think this is a perfect onboarding strategy. |
|
@xabier looks like a nice idea. At the moment this was the quickest solution, but we can definitely improve this, as well as lots of other call to actions that could prompt the user to register. |
|
@josepjaume A disabled button is disencouraging and disempowering, a clickable button is ... clickable! then I click and I am asked to proceed to sign-in/up, lets keep this in mind! if this is a quick fix is fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
When an anonymous user (lot logged in) visits a followable resource, we didn't show any "Follow" button. This PR adds a disabled "Follow" button so the user cannot click it, but knows that the action can be performed. It also shows a tooltip prompting the user to sign in before following.
📌 Related Issues
📋 Subtasks
None
📷 Screenshots (optional)