Remove rectify weirdness on surveys #3055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #3055 +/- ##
==========================================
+ Coverage 98.59% 98.59% +<.01%
==========================================
Files 1716 1717 +1
Lines 40967 40980 +13
==========================================
+ Hits 40393 40406 +13
Misses 574 574 |
|
@deivid-rodriguez this hotfix has the test suite passing! 🎉 Should we wait until the |
deivid-rodriguez
force-pushed
the
remove_rectify_weirdness_on_surveys
branch
from
b07406c
to
bf5abae
Compare
|
I think it's better to ship the monkeypatch for now so I can keep working under sanity, and also because |
mrcasals
previously approved these changes
Mar 21, 2018
The way surveys are structured made me introduce a nasty hack in the survey question form. However, now I'm adding new attributes to the form and I'm having trouble unit testing them since this form is now instantiated very weirdly. I discovered that this is actually something rectify just can't handle and I figured it's better to add support for it upstream. For now I'm adding the monkey patch here until the upstream PR is attended.
deivid-rodriguez
force-pushed
the
remove_rectify_weirdness_on_surveys
branch
from
bf5abae
to
894e6c1
Compare
|
I simplified the patch to |
mrcasals
approved these changes
Mar 22, 2018
|
OK then, going in! |
Merged
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Yesterday I almost went crazy figuring out why things were not working for our nested survey forms. I ended up adding two hacks to the answer form model to make it work:
However, these hacks are biting me now since I'm adding more attributes to this form, and I cannot easily unit test them, because the form is now instantiated wierdly.
I digged in a little deeper and it seems like a bug / missing feature in
rectifyto me: it only supports one-level nested forms. I added a fix for it in andypike/rectify#45, but I'm opening this PR monkeypatching it to see how the patch plays against the whole of decidim's test suite.With this, I can remove both hacks mentioned before.
📌 Related Issues
📋 Subtasks
None.
📷 Screenshots (optional)
None.