Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix debate times #3071

Merged
merged 1 commit into from
Mar 22, 2018
Merged

Fix debate times #3071

merged 1 commit into from
Mar 22, 2018

Conversation

oriolgual
Copy link
Contributor

@oriolgual oriolgual commented Mar 22, 2018

🎩 What? Why?

We need to take into account time zones when accepting time inputs from users.

📌 Related Issues

📋 Subtasks

  • Add CHANGELOG entry

@ghost ghost assigned oriolgual Mar 22, 2018
@ghost ghost added the status: WIP label Mar 22, 2018
mrcasals
mrcasals previously approved these changes Mar 22, 2018
@codecov
Copy link

codecov bot commented Mar 22, 2018

Codecov Report

Merging #3071 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3071      +/-   ##
==========================================
+ Coverage   98.58%   98.59%   +<.01%     
==========================================
  Files        1717     1716       -1     
  Lines       40992    40967      -25     
==========================================
- Hits        40414    40393      -21     
+ Misses        578      574       -4

@josepjaume
Copy link
Contributor

We should backport this, right?

@mrcasals
Copy link
Contributor

@josepjaume yes, I think so

@mrcasals mrcasals merged commit d70f0a7 into master Mar 22, 2018
@mrcasals mrcasals deleted the fix-debates-times branch March 22, 2018 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants