Fix/accountability progress #3952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
deivid-rodriguez
previously approved these changes
Aug 2, 2018
CHANGELOG.md
Outdated
| @@ -45,6 +45,7 @@ | |||
|
|
|||
| **Fixed**: | |||
|
|
|||
| - **decidim-ac countability**: Fix progress when provided. [\#3952](https://github.com/decidim/decidim/pull/3952) | |||
There was a problem hiding this comment.
There's a 🐛'gy whitespace here :) Also, the text is a bit vague, better to say "Fix accountability progress to be between 0 and 100 if provided" like in the PR description!
There was a problem hiding this comment.
Thanks for your feedback !
|
@armandfardeau thanks for the PR! It's weird you got that number, did you manually modify the values from the DB or was it done by Decidim itself? |
|
@mrcasals I didn't change anything in DB, I've juste updated the form. As there is no validation on form nor model, you could submit everything you wanted. Please let me know if validation on model is needed. |
|
No, it's good as it is! 😄 |
This was referenced Aug 3, 2018
mrcasals
approved these changes
Aug 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Fix accountability progress to be between 0 and 100 if provided
Progress was not constrained to a range, you could choose a number superior to 100 resulting in error.
The range is now within 0 to 100 and can be empty.
Fixes #3956
📋 Subtasks
CHANGELOGentry📷 Screenshots (optional)