Gamification (badges) #3975
Merged
Gamification (badges) #3975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
oriolgual
reviewed
Aug 7, 2018
| private | ||
|
|
||
| def status | ||
| Decidim::Gamification.status_for(user, badge.name) |
|
|
||
| delegate :current_user, to: :controller | ||
|
|
||
| def show |
There was a problem hiding this comment.
I think this kind of show is not necessary
oriolgual
suggested changes
Aug 10, 2018
| include Decidim::Core::Engine.routes.url_helpers | ||
| include Decidim::IconHelper | ||
|
|
||
| delegate :current_user, to: :controller, prefix: false |
| # inconsistent. | ||
| # | ||
| # Returns nothing. | ||
| def self.reset_badges(users = User.all) |
There was a problem hiding this comment.
Should we prevent this at production?
There was a problem hiding this comment.
I think it's actually most useful in production, in case there's any data loss or inconsistency.
| validates :levels, empty: false | ||
|
|
||
| validate do | ||
| errors.add(:levels, "level thresholds should be ordered") if levels.sort != levels |
There was a problem hiding this comment.
These messages aren't meant to reach user interfaces - it's an internal consistency validation. I don't think I18n make sense here.
| @@ -24,6 +24,7 @@ def call | |||
|
|
|||
| transaction do | |||
| @proposal.update published_at: Time.current | |||
| Decidim::Gamification.increment_score(@current_user, :proposals) | |||
There was a problem hiding this comment.
Maybe increment the score for all the authors?
There was a problem hiding this comment.
Will look into that.
josepjaume
force-pushed
the
feature/badges
branch
from
ee24cd2
to
0d064ef
Compare
oriolgual
approved these changes
Aug 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This feature adds user badges, which are earned when certain actions are performed.
📌 Related Issues
📋 Subtasks
CHANGELOGentry📷 Screenshots (optional)
None