Add User groups profiles #4196
Merged
Add User groups profiles #4196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrcasals
force-pushed
the
user-groups/add-profile
branch
3 times, most recently
from
5685262
to
149639b
Compare
mrcasals
force-pushed
the
user-groups/add-profile
branch
from
49134eb
to
a9284b4
Compare
mrcasals
force-pushed
the
user-groups/add-profile
branch
from
fd19aa0
to
230d84f
Compare
mrcasals
force-pushed
the
user-groups/add-profile
branch
from
b7fa9ce
to
bc7f7b3
Compare
ghost
added
the
oriolgual
previously approved these changes
Oct 4, 2018
|
We tried the migrations locally and everything looks good! Waiting for tests to merge this. |
oriolgual
approved these changes
Oct 4, 2018
tramuntanal
pushed a commit
that referenced
this pull request
Oct 9, 2018
* Migrate user groups to users table * Set correct default scopes * Show user group profiles * Use `profile_holder` instead of `user` as a helper * Fix User Group presenter * Fix user group factory * Move migration where it should belong * Fix some tests * Fix rubocop issues * Improve data migration * Fix RegistrationForm specs * Fix specs * Fix rubocop complaints * Fix admin specs * Fix index on migration * Fix proposals specs * Fix rubocop complaints * Show user groups profiles * Fix more rubocop lint errors * Migrate proposals endorsements * Fix user groups IDs on comments * Fix data on debates * Fix data on initiatives * Fix data on consultations * Add changelog entry * Redirect to correct action so that links highlight properly * Don't let user groups be contacted by now * Register UserGroup resource so that cards work * Pass the current user as a context for the profile cells * Tweak profile sidebar * Fix presenters * Fix specs * Fix migration
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR is a base work for #3893. This PR adds the ability to show user groups profiles.
📌 Related Issues
📋 Subtasks
CHANGELOGentryUserGroupsto the same table asUsers(move the model, add migration)myhost.com/profiles/:nickname(fix presenters)📷 Screenshots (optional)
Authors inline (left is a user group, right is a normal user):
Clicking on the nickname of that user group takes you to its profile page:
