Feature/apply media design and links #4285
Conversation
ghost
assigned 
|
@decidim/lot-core CircleCI tests have finished, but test checks does not show it correctly. "upload_coverage" say "Runing", but when you go to CircleCi page, it is "succeedded" |
|
@isaacmg410 yes, we already notified CircleCI about this. |
|
@mrcasals okey! then, can this PR be reviewed? |
|
@isaacmg410 there are some conflicts now, can you check them please? |
|
@mrcasals conflicts solved! |
|
@decidim/lot-core It says that all tests are waiting for status, but, when you go to https://circleci.com/workflow-run/eaa3cec9-678c-49ec-acaf-dfad8c701102?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-checks-link all testes are green |
|
@mrcasals requested changes applied. 😄 |
|
@decidim/lot-core ready to be merged |
| @@ -0,0 +1,10 @@ | |||
| <% if model.any? %> | |||
There was a problem hiding this comment.
Move this logic to the show method of the cell
| include Decidim::ApplicationHelper | ||
| include Decidim::SanitizeHelper | ||
|
|
||
| def show |
There was a problem hiding this comment.
Add return unless models.any? here and remove it from the views
| @form = form(Decidim::Conferences::Admin::MediaLinkForm).instance | ||
| end | ||
|
|
||
| def create |
There was a problem hiding this comment.
Looks like this action is not tested, can you add a system spec for this please?
There was a problem hiding this comment.
ups. I have forgotten
| uri = URI.parse(link) | ||
| errors.add :link, :invalid if !uri.is_a?(URI::HTTP) || uri.host.nil? | ||
| rescue URI::InvalidURIError | ||
| errors.add :link, :invalid |
There was a problem hiding this comment.
Can you add tests for this case please?
| es: "Media Link es", | ||
| ca: "Media Link ca" | ||
| ) | ||
| # fill_in_i18n( |
|
@decidim/lot-core requested changes applied 😄 |
isaacmg410
changed the title
isaacmg410
changed the title
|
@isaacmg410 rubocop is complaining, can you check it? 😄 |
|
@mrcasals done |
🎩 What? Why?
This PR adds the new design of Uploaded Attachments to a Conference, and add the MediaLinks entity
📌 Related Issues
📋 Subtasks
CHANGELOGentry📷 Screenshots (optional)