Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hashtags autocomplete #4590

Merged
merged 5 commits into from
Nov 29, 2018

Conversation

leio10
Copy link
Contributor

@leio10 leio10 commented Nov 28, 2018

🎩 What? Why?

When writing proposal content, hashtags autocomplete shows an "undefined" text when there are no existing hashtags as the written one. This occurs because there is no message defined to show when there are no results (data-noresults).
This PR updates the used library and allows to hide the autocomplete where there are no existing hashtags that matches the written one.

📌 Related Issues

📋 Subtasks

  • Add CHANGELOG entry

📷 Screenshots (optional)

before:
peek 28-11-2018 15-06

after:
peek 28-11-2018 15-07

@ghost ghost assigned leio10 Nov 28, 2018
@ghost ghost added the status: WIP label Nov 28, 2018
@mrcasals
Copy link
Contributor

Wohoo, thanks @leio10!

@mrcasals mrcasals merged commit 3a9f9b8 into decidim:master Nov 29, 2018
@leio10 leio10 deleted the fix/hashtags_autocomplete branch December 4, 2018 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants