Keep proposal new values for title and body when editing and receiving an error message #4592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
leio10
force-pushed
the
fix/edit_proposals
branch
from
4300c1f
to
dc695c1
Compare
mrcasals
previously approved these changes
Nov 29, 2018
mrcasals
previously approved these changes
Nov 30, 2018
|
@mrcasals it seems that the failed test is a flaky, can you please rerun it? Thanks! |
|
@leio10 re-scheduled! |
|
@mrcasals it failed again 😞, but I have no idea about that error. It doesn't seems to be related to this PR. What can I do to fix that? 🤔 |
|
Mhhh the problem seems to appear after merging #4578, let me ask @oriolgual and see if we find something. The merge commit for that PR failed with the same exact error as this PR, but later merges are green 😕 |
leio10
force-pushed
the
fix/edit_proposals
branch
from
e01713a
to
25ebb93
Compare
|
Yeah! Now is green, thanks @mrcasals!! |
mrcasals
approved these changes
Nov 30, 2018
|
Yay, merged! Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
When a user is trying to edit a proposal and receives an error message, values for title and body fields are reset to proposal original values, losing his last modifications.
This PR fixes this bug using the form value instead of the model value. This is done allowing the
presenthelper to receive the form and the presenter class to be used.📌 Related Issues
📋 Subtasks
CHANGELOGentry📷 Screenshots (optional)