Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't eager-load polymorphic relations #4614

Merged
merged 2 commits into from
Dec 4, 2018
Merged

Don't eager-load polymorphic relations #4614

merged 2 commits into from
Dec 4, 2018

Conversation

oriolgual
Copy link
Contributor

@oriolgual oriolgual commented Dec 4, 2018 •
edited
Loading

🎩 What? Why?

Authors can be polymorphic and cannot be eager loaded, fixes https://sentry.io/share/issue/a08b80b557a442f88246f5ecbd09d83f/

📋 Subtasks

  • Add CHANGELOG entry

@ghost ghost assigned oriolgual Dec 4, 2018
@ghost ghost added the status: WIP label Dec 4, 2018
@oriolgual oriolgual merged commit 4c5ac5c into master Dec 4, 2018
@oriolgual oriolgual deleted the fix-initiatives-preload branch December 4, 2018 13:34
@oriolgual oriolgual mentioned this pull request Mar 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrcasals mrcasals mrcasals approved these changes

Assignees

@oriolgual oriolgual

Labels
in-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oriolgual @mrcasals