Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix iniative edit when missing scope #4634

Merged
merged 3 commits into from
Dec 5, 2018
Merged

Fix iniative edit when missing scope #4634

merged 3 commits into from
Dec 5, 2018

Conversation

oriolgual
Copy link
Contributor

🎩 What? Why?

Instead of crashing provide a fallback to the scope name.

📌 Related Issues

📋 Subtasks

  • Add CHANGELOG entry

@ghost ghost assigned oriolgual Dec 5, 2018
@ghost ghost added the status: WIP label Dec 5, 2018
mrcasals
mrcasals previously approved these changes Dec 5, 2018
View reviewed changes
@ghost ghost assigned mrcasals Dec 5, 2018
@ghost ghost added the status: WIP label Dec 5, 2018
@mrcasals mrcasals merged commit 7d73e36 into master Dec 5, 2018
@ghost ghost removed the status: WIP label Dec 5, 2018
@mrcasals mrcasals deleted the fix-iniative-edit-when-missing-scope branch December 5, 2018 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrcasals mrcasals mrcasals approved these changes

Assignees

@oriolgual oriolgual

@mrcasals mrcasals

Labels
in-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oriolgual @mrcasals