Fix/4765 participatory texts error uploading utf 8 files #4788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned …f making code climate crash/fail.
…ulprit of making code climate crash/fail." because code climate grep engine still fails without this line. This reverts commit 52976bd.
|
Hi @decidim/lot-core do you have any hint on why CodeClimate is failing due to "We had trouble running the grep engine."? |
Maybe it's related to |
|
Could you also review de conflicts please? |
… CC's grep engine configuration.
3 tasks
oriolgual
approved these changes
Jan 29, 2019
tramuntanal
deleted the
fix/4765-participatory_texts_error_uploading_utf-8_files
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
In Participatory texts, do not crash when uploading plain text files from unknown encodings.
📌 Related Issues
📋 Subtasks
CHANGELOGentrycharlock_holmesgem.Decidim::IoEncodingindecidim-core.Decidim::IoEncoding.to_standard_encodingto incoming Markdown files.Screenshots
Uploading file with accents and non ascii symbols is now ok.
The rendering in the last paragraph:
