[FIX] Promote URLs in plain text to HTML anchors after strip_tags. #5341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@decidim/lot-core this PR is ready for review |
oriolgual
suggested changes
Sep 19, 2019
decidim-core/spec/content_renderers/decidim/hashtag_renderer_spec.rb
Outdated
Show resolved
Hide resolved
Co-Authored-By: Oriol Gual <oriolgual@users.noreply.github.com>
[REFACTOR] Also added target blank and rel noopener.
|
@oriolgual @decidim/lot-core I've simplified this PR to simply converting plain text URLs to anchors. Ready |
… Proposal and CollaborativeDrafts.
oriolgual
reviewed
Sep 20, 2019
oriolgual
previously approved these changes
Sep 20, 2019
oriolgual
approved these changes
Sep 23, 2019
4 tasks
|
@tramuntanal I've deployed this to staging and it doesn't seem to work OK:
http://staging.decidim.codegram.com/processes/itaque-voluptatem/f/3/proposals/43 |
|
Yes, I'll check! |
5 tasks
oriolgual
added a commit
that referenced
this pull request
Sep 26, 2019
oriolgual
added a commit
that referenced
this pull request
Sep 27, 2019
* Fix order to escape proposal content. Related to #5341 * Revert spec changes
5 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Links in Proposal's body disappear.
I'm doing one thing in this PR:
Discarded:
📌 Related Issues
📋 Subtasks
CHANGELOGentry📷 Screenshots (optional)
When entering "Content with <a href="http://urls.net" onmouseover="alert(document.cookies)">URLs</a> of anchor type and text urls like https://decidim.org." in the body of a Proposal, it gets rendered as follows: