Fix order to escape proposal content #5367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tramuntanal
reviewed
Sep 26, 2019
| end | ||
| text | ||
|
|
||
| Anchored::Linker.auto_link(text, target: "_blank", rel: "noopener") |
There was a problem hiding this comment.
Today I was thinking to open a new PR because text links are always promoted to anchors. But there's already a links flag that we can reuse and make the behavior more consistent.
What's your opinion, do you want me to open a new PR with this change?
There was a problem hiding this comment.
Suggested change
| Anchored::Linker.auto_link(text, target: "_blank", rel: "noopener") | |
| text = Anchored::Linker.auto_link(text, target: "_blank", rel: "noopener") if links | |
| text |
There was a problem hiding this comment.
Yes, that makes sense @tramuntanal!
| end | ||
| text | ||
|
|
||
| Anchored::Linker.auto_link(text, target: "_blank", rel: "noopener") |
As you can see at MetaDecidim, there's some double escaping and apostrophes are being displayed as html entities. |
This was referenced Sep 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃帺 What? Why?
We need to escape & strip before executing the hashtag renderer to maintain the same workflow as before.
馃搶 Related Issues