Use followers counter cache when available #6383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The proposal model does not have a `followers_count` column so we need to provide a fallback. Other models avoid an N+1. Then, we need to find out why proposals don't have followers counter-cached. If they did, we would avoid another N+1.
mrcasals
approved these changes
Aug 6, 2020
|
@decidim/core can you review this, please? It improves the performance of the FollowButton cell, thus improving the performance of all indexs pages rendering it. Thanks! |
agustibr
approved these changes
Aug 12, 2020
tramuntanal
approved these changes
Aug 13, 2020
@tramuntanal can we do that in a future PR, please? @sauloperez is on holidays and we don't have enough people to take over this PR right now, and this might end up forgotten :( |
|
Yes @mrcasals , I think it wouldn't be a problem. By the moment, I accept this PR and we'll wait for another PR later with the correction requested by @tramuntanal |
Quentinchampenois
pushed a commit
to Quentinchampenois/decidim
that referenced
this pull request
Aug 14, 2020
The proposal model does not have a `followers_count` column so we need to provide a fallback. Other models avoid an N+1. Then, we need to find out why proposals don't have followers counter-cached. If they did, we would avoid another N+1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Investigating proposals' performance together with @mrcasals we found out that a considerable amount of the time is spent rendering coauthorships (all that complexity comes at a cost). Among that, a big issue was an N+1 fetching the authors' followers.
We thought a counter cache had to be added but it turns out it already existed 🎉 ! However,
Proposals::Proposaldoesn't implement it and thus, we need to provide a fallback for now. It can be added in a separate PR (I'm not sure I'll get it done before going on holidays)In my machine, this gets from
to
I assume the impact will be noticeable in a production env more than we see here ☝️
📌 Related Issues
📋 Subtasks
CHANGELOGupgrade notes, if required📷 Screenshots (optional)