-
-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix proposal creation #6518
Fix proposal creation #6518
Conversation
They are not i18n-powered yet.
Hi @decidim/product! When we moved proposals to i18n back in #6285 (and related #6384) we introduced a few bugs, this PR solves them. But also, this PR adds the ability for admin users to create i18n proposals from the admin site. This means official proposals can be translated! And only official proposals: we've skipped participatory texts, and non-admin users can only create proposals in their current language. We think this is more consistent to the rest of the admin. We've opened a review app here: https://decidim-staging-pr-169.herokuapp.com/ can you check it out, please? |
@mrcasals I checked this, working as expected! I just found that there are new validation rules that step on each other, but I don't know if this has been introduced by this PR: |
@carolromero I suspect we always had this problem, but never realized it. I went back to Can we open an issue to keep track of that problem? |
@mrcasals must be recent because in release 0.22 it does not yet appear, my bet it has come up with some of the accessibility changes
Yes, we can! Right away 😄 |
@carolromero Thanks!! @decidim/core can you review this, please? 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @mrcasals. Thanks!
🎩 What? Why?
After #6285 and #6384, some bugs were still found:
This PR solves both issues.
📌 Related Issues
📋 Subtasks
None
📷 Screenshots (optional)
None