Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix proposal creation #6518

Merged
merged 15 commits into from
Sep 18, 2020
Merged

Fix proposal creation #6518

merged 15 commits into from
Sep 18, 2020

Conversation

mrcasals
Copy link
Contributor

🎩 What? Why?

After #6285 and #6384, some bugs were still found:

  • In some cases, proposal title and body were persisted as simple strings, instead of JSONB content in the DB.
  • Proposals couldn't be created as i18n from the admin side.

This PR solves both issues.

📌 Related Issues

📋 Subtasks

None

📷 Screenshots (optional)

None

@mrcasals
Copy link
Contributor Author

mrcasals commented Sep 16, 2020

Hi @decidim/product! When we moved proposals to i18n back in #6285 (and related #6384) we introduced a few bugs, this PR solves them. But also, this PR adds the ability for admin users to create i18n proposals from the admin site. This means official proposals can be translated! And only official proposals: we've skipped participatory texts, and non-admin users can only create proposals in their current language. We think this is more consistent to the rest of the admin.

We've opened a review app here: https://decidim-staging-pr-169.herokuapp.com/ can you check it out, please?

@carolromero
Copy link
Member

@mrcasals I checked this, working as expected! I just found that there are new validation rules that step on each other, but I don't know if this has been introduced by this PR:

imatge

@mrcasals mrcasals marked this pull request as ready for review September 16, 2020 14:50
@mrcasals
Copy link
Contributor Author

@carolromero I suspect we always had this problem, but never realized it. I went back to develop and tried it out (notice how the fields are not i18n):

image

Can we open an issue to keep track of that problem?

@carolromero
Copy link
Member

@mrcasals must be recent because in release 0.22 it does not yet appear, my bet it has come up with some of the accessibility changes
imatge

Can we open an issue to keep track of that problem?

Yes, we can! Right away 😄

@mrcasals
Copy link
Contributor Author

@carolromero Thanks!!

@decidim/core can you review this, please? 😄

Copy link
Contributor

@ivan-mr ivan-mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @mrcasals. Thanks!

@ivan-mr ivan-mr merged commit 2dfdd3a into develop Sep 18, 2020
@ivan-mr ivan-mr deleted the proposals/fix-creation branch September 18, 2020 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants