Add preview of questions to an election #6749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slickepinne
force-pushed
the
feature/add-election-information
branch
from
24c4970
to
b2be827
Compare
agustibr
reviewed
Oct 28, 2020
| <p> | ||
| <%= t(".questions_preview.description") %>: | ||
| </p> | ||
| <ul class="accordion js-sortable mb-m evote__preview" |
There was a problem hiding this comment.
Seems like the .js-sortable class is not used to style nor give some functionality, so I'd suggest removing it:
Suggested change
| <ul class="accordion js-sortable mb-m evote__preview" | |
| <ul class="accordion mb-m evote__preview" |
|
Hi @slickepinne can you please give feedback to @agustibr 's suggestion? and ping us when the PR is ready? |
tramuntanal
reviewed
Oct 30, 2020
I'm on it! 👍 |
slickepinne
force-pushed
the
feature/add-election-information
branch
from
b2be827
to
05bbc0e
Compare
|
@tramuntanal I added the changes. 😄 Hope it's okay, now. |
tramuntanal
approved these changes
Nov 3, 2020
mrcasals
added
module: elections
type: feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR adds an accordion to an election page that shows the related questions and answers.
📌 Related Issues
Testing
Go to the public elections module and click on one of the elections. That page shows an accordion below the election information.
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.📷 Screenshots
By default, the accordion is collapsed:
You can see the answers when you click on the question:
