-
-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add preview of questions to an election #6749
Conversation
24c4970
to
b2be827
Compare
<p> | ||
<%= t(".questions_preview.description") %>: | ||
</p> | ||
<ul class="accordion js-sortable mb-m evote__preview" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like the .js-sortable
class is not used to style nor give some functionality, so I'd suggest removing it:
<ul class="accordion js-sortable mb-m evote__preview" | |
<ul class="accordion mb-m evote__preview" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Hi @slickepinne can you please give feedback to @agustibr 's suggestion? and ping us when the PR is ready? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM bug waiting for feedback to Agusti's comment
I'm on it! 👍 |
b2be827
to
05bbc0e
Compare
@tramuntanal I added the changes. 😄 Hope it's okay, now. |
🎩 What? Why?
This PR adds an accordion to an election page that shows the related questions and answers.
📌 Related Issues
Testing
Go to the public elections module and click on one of the elections. That page shows an accordion below the election information.
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/
.📷 Screenshots
By default, the accordion is collapsed:
You can see the answers when you click on the question: