Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add image and CTA Content Block in Process Groups #6821

Closed
wants to merge 33 commits into from
Closed

Add image and CTA Content Block in Process Groups #6821

wants to merge 33 commits into from

Conversation

entantoencuanto
Copy link
Contributor

🎩 What? Why?

  • Adds a CTA content block which admits an image
  • Registers this content block in participatory process groups landing page
  • Adds some system tests for participatory process groups landing page

Note: This PR is built on top of feature/process_groups_improvements-metadata_title_content_block, the branch of #6699 PR.

📌 Related Issues

Testing

This block has been registered in participatory process groups

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Description

♥️ Thank you!

@entantoencuanto entantoencuanto mentioned this pull request Nov 6, 2020
Closed
12 tasks
@entantoencuanto entantoencuanto force-pushed the feature/process_groups_improvements-cta_content_block branch from 7411ab3 to fa9b223 Compare November 10, 2020 16:05
@entantoencuanto entantoencuanto force-pushed the feature/process_groups_improvements-cta_content_block branch from fa9b223 to 23217e6 Compare November 11, 2020 16:33
@entantoencuanto entantoencuanto marked this pull request as ready for review November 16, 2020 11:55
@andreslucena andreslucena changed the title Feature/process groups improvements cta content block Add image and CTA Content Block in Process Groups Nov 17, 2020
@entantoencuanto
Add migration to add a hashtag column to decidim_participatory_proces…
c75f95c 
…s_groups table
@entantoencuanto
Add factories and admin management from admin of groups hashtag
0e41cbe
@entantoencuanto
Add migration to include metadata columns in decicim_participatory_pr…
7fc382f 
…ocess_groups table
@entantoencuanto
Add factories and admin management from admin of groups metadata
5673fab 
The hashtag attribute has been moved to the metadata section in admin
form
@entantoencuanto
Add validation to group_url participatory process group form attribute
b581c56
@entantoencuanto
Change participatory_process_group homepage to display only content b…
cf14edf 
…locks
@entantoencuanto
Create and register title content block for groups homepage
c39be4b 
This content block contains title, description, number of participatory
processes and hashtag, external url and meta scope if present
@entantoencuanto
Add html content block and remove hero
acb4ddb
@entantoencuanto
Improve meta_scope obtaining in title cell
d92e2b0
@entantoencuanto
Avoid errors if group hashtag is nil
000200c
@entantoencuanto
Get resource in groups title_cell from model scoped_resource_id inste…
975af20 
…ad of controller
@entantoencuanto
Add title content block for groups cell tests
ca2e26e
@entantoencuanto
Add migration to change groups name column and serialized data in ver…
d952497 
…sions
@entantoencuanto
Replace references to name with title in participatory process groups
e433a08
@entantoencuanto
Update participatory process groups system test to check title block
b6efc87
@entantoencuanto
Add metadata content block cell to decidim-participatory_processes
10aabc8
@entantoencuanto
Register metadata content block in participatory process groups landi…
d009375 
…ng page
@entantoencuanto
Add system tests for metadata content block in participatory process …
b225157 
…groups landing page
@entantoencuanto
Remove no longer used proposals view hook for process groups
fd1e5de
@entantoencuanto
Remove no longer used accountability results view hook for process gr…
981e520 
…oups
@entantoencuanto
Remove no longer used meetings view hook for process groups
898b8de
@entantoencuanto
Fix translations issues
f8bfd16
@entantoencuanto
Fix rubocop offenses
ca44ff8
@entantoencuanto entantoencuanto force-pushed the feature/process_groups_improvements-cta_content_block branch from 23217e6 to 992f402 Compare November 27, 2020 23:08
@tramuntanal
Copy link
Contributor

@entantoencuanto can you resolve conflicting files please?

@tramuntanal
Copy link
Contributor

tramuntanal commented Dec 3, 2020 •
edited

Zero files from develop changed @entantoencuanto ... was this PR superseeded by some other of your PRs?

@entantoencuanto
Copy link
Contributor Author

The branches of the PRs of this project are made one after other, so the branch of a PR contains the commits of the previous ones. This is the order of the PRs:

So the merging #6823, involves also merging the changes of #6699, #6821 and #6822. Sorry for the inconvenience.

@tramuntanal
Copy link
Contributor

Closing then as changes in this PR were already merged by #6823

@tramuntanal tramuntanal closed this Dec 4, 2020
This was referenced Dec 4, 2020
Closed
Closed
@tramuntanal tramuntanal deleted the feature/process_groups_improvements-cta_content_block branch December 9, 2020 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeclimate codeclimate[bot] codeclimate left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add image and CTA in Process Groups
3 participants
@entantoencuanto @tramuntanal @Leusev