Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements in Process Groups and processes block #6853

Conversation

entantoencuanto
Copy link
Contributor

  • Fixes a query returning wrong results when current user is admin
  • Includes promoted groups in organization homepage highlighted processes:
    • The promoted groups are prioritized over the groups and displayed first
    • If there is only a promoted group it's shown using the same partial used for promoted groups in processes index
  • Adds some system tests to homepage to check the block

Note: This PR is built on top of feature/process_groups_improvements-highlighted_groups, the branch of #6828 PR.

📌 Related Issues

Link your PR to an issue

Testing

Enable this block in organization homepage

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Description

♥️ Thank you!

@entantoencuanto entantoencuanto force-pushed the feature/process_groups_improvements-groups_and_processes_block branch 2 times, most recently from 212cbed to 622899e Compare November 16, 2020 15:59
@entantoencuanto entantoencuanto marked this pull request as ready for review November 16, 2020 18:19
@entantoencuanto entantoencuanto force-pushed the feature/process_groups_improvements-groups_and_processes_block branch 2 times, most recently from 31d25cc to 85b65f3 Compare November 30, 2020 19:13
@tramuntanal tramuntanal changed the base branch from develop to feature/process_groups_improvements-highlighted_groups December 4, 2020 07:53
@tramuntanal
Copy link
Contributor

Can you rebase please with feature/process_groups_improvements-highlighted_groups ? @entantoencuanto

@andreslucena andreslucena changed the title Feature/process groups improvements groups and processes block Improvements in Process Groups and processes block Dec 4, 2020
@entantoencuanto entantoencuanto force-pushed the feature/process_groups_improvements-highlighted_groups branch from 6c9ebfe to a3caf92 Compare December 4, 2020 20:39
@entantoencuanto entantoencuanto force-pushed the feature/process_groups_improvements-groups_and_processes_block branch from f0066f7 to df52cfb Compare December 4, 2020 20:47
Base automatically changed from feature/process_groups_improvements-highlighted_groups to develop December 9, 2020 11:04
@tramuntanal tramuntanal merged commit 488fdbc into develop Dec 9, 2020
@tramuntanal tramuntanal deleted the feature/process_groups_improvements-groups_and_processes_block branch December 9, 2020 12:45
@mrcasals mrcasals added module: participatory processes type: feature PRs or issues that implement a new feature labels Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: participatory processes type: feature PRs or issues that implement a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Highlighted process groups content block in Homepage
4 participants