Notification to initiative authors / promotor committee #7028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulinebessoles
suggested changes
Dec 21, 2020
There was a problem hiding this comment.
Hi @armandfardeau ! I checked in local, and it seems HTML anchors are not accepted for email_intro and email_outro, so I re-wrote the translation keys accordingly. Sorry for the mistake :)
Co-authored-by: Pauline Bessoles <52420208+paulinebessoles@users.noreply.github.com>
|
This works perfectly, thanks @armandfardeau! |
|
@armandfardeau watch out, the lint job is failing! |
|
@carolromero could you confirm this can be merged? |
andreslucena
previously requested changes
Jan 26, 2021
Hi @paulinebessoles just chiming in to confirm this can be merged once the tiny changes suggested by Andrés are accepted. Thanks for the PR @armandfardeau |
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
|
@mrcasals Hi, everything is in order here, tell me if you need anything. |
armandfardeau
added a commit
to OpenSourcePolitics/decidim
that referenced
this pull request
Feb 8, 2021
armandfardeau
added a commit
to OpenSourcePolitics/decidim
that referenced
this pull request
Feb 8, 2021
* Backport decidim#7028 * Normalize locales * Add missing fr translation * Update decidim-initiatives/config/locales/fr.yml Co-authored-by: Pauline Bessoles <52420208+paulinebessoles@users.noreply.github.com> * Update decidim-initiatives/config/locales/fr.yml * Update decidim-initiatives/config/locales/fr.yml * Update decidim-initiatives/config/locales/fr.yml * Update decidim-initiatives/config/locales/fr.yml * Update decidim-initiatives/config/locales/fr.yml * Update decidim-initiatives/config/locales/fr.yml * Update decidim-initiatives/config/locales/fr.yml * Update decidim-initiatives/config/locales/fr.yml * Update decidim-initiatives/config/locales/fr.yml * Update decidim-initiatives/config/locales/fr.yml Co-authored-by: Pauline Bessoles <52420208+paulinebessoles@users.noreply.github.com> * Update decidim-initiatives/config/locales/fr.yml Co-authored-by: Pauline Bessoles <52420208+paulinebessoles@users.noreply.github.com> * Update decidim-initiatives/config/locales/fr.yml Co-authored-by: Pauline Bessoles <52420208+paulinebessoles@users.noreply.github.com> * Update decidim-initiatives/config/locales/fr.yml Co-authored-by: Pauline Bessoles <52420208+paulinebessoles@users.noreply.github.com> * Update decidim-initiatives/config/locales/fr.yml * Update decidim-initiatives/config/locales/fr.yml Co-authored-by: Pauline Bessoles <52420208+paulinebessoles@users.noreply.github.com> * Update decidim-initiatives/config/locales/fr.yml Co-authored-by: Pauline Bessoles <52420208+paulinebessoles@users.noreply.github.com> * Update decidim-initiatives/config/locales/fr.yml Co-authored-by: Pauline Bessoles <52420208+paulinebessoles@users.noreply.github.com> * Update decidim-initiatives/config/locales/fr.yml Co-authored-by: Pauline Bessoles <52420208+paulinebessoles@users.noreply.github.com> * Update decidim-initiatives/config/locales/fr.yml Co-authored-by: Pauline Bessoles <52420208+paulinebessoles@users.noreply.github.com> * Fix malformed yaml * Fix en offenses Co-authored-by: Pauline Bessoles <52420208+paulinebessoles@users.noreply.github.com>
mrcasals
added
module: initiatives
type: feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
The author is not notified when a user tries to join the promoter committee
The candidate to the promoting committee is not notified when its application is accepted or rejected.
This results in both parties not managing the initiative as its specification is intended.
As an author, I want to receive a notification when a user applies to join the promoting committee of my initiative
As a promoting committee candidate I want to receive a notification when my application is accepted
As a promoting committee candidate I want to receive a notification when my application is rejected
📌 Related Issues
Link your PR to an issue
Testing
Describe the best way to test or validate your PR.
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.