-
-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional order for initiative content block #7047
Add optional order for initiative content block #7047
Conversation
I think the survey tests failure is flaky, could you reload it? |
@armandfardeau I restarted the job! |
Thanks @mrcasals |
@armandfardeau while we review the code, I suspect @decidim/product will want to check it out, can you push this somewhere so they can test it out? |
...s/app/cells/decidim/initiatives/content_blocks/highlighted_initiatives_settings_form_cell.rb
Outdated
Show resolved
Hide resolved
|
@decidim/product can you review this, please? 😄 |
@armandfardeau quick question: I see one of the sorting options says 'Default (unordered)'. Does this mean 'random' order? If so, can we change the string from 'unordered' to 'random'? Thanks! |
The default order returns items based on an active record query. It may appear to the human eye as random but cannot be qualified as such. This is why we preferred the term unordered. |
@carolromero Do you still want us to change the sorting option name or can this PR be merged? |
@paulinebessoles @armandfardeau we didn't know about this default order "Unordered" and it doesn't make any sense, can you guys please change it so that the default order is by date of creation? 🙏 |
No problem @carolromero , we'll swap the two display options to make the default=most recent! |
@mrcasals Hi, everything is in order here, tell me if you need anything. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good!
🎩 What? Why?
This feature modify the edit page of the initiative homepage content block, as well as the order of the initiatives displayed in FE on the homepage.
📌 Related Issues
Testing
Create an initiative Highlighted initiatives homepage content block, select order element by most recent.
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/
.📷 Screenshots