Fix map accessibility issue - Map bottom position missing label #7763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All links need to have an accessibility label. This changes the element to div which does not have this requirement.
ahukkanen
changed the title
mrcasals
approved these changes
Apr 6, 2021
mrcasals
added
type: feature
entantoencuanto
added a commit
that referenced
this pull request
Apr 6, 2021
* develop: Census access codes exportation flow (#7756) Show attachment menu as active only when subitem is active (#7774) Add Voting Ballot Styles (#7779) Fix map accessibility issue - Map bottom position missing label (#7763) Update README.adoc (#7687) Fix single initiative type (#7667) Enable Proposals Cell to take into account machine translations (#7629) Change order by weight in subassemblies (#7620) Add categories parent filter to API (#7609) Mockup design for Remaining time in voting (#7597) Upgrade to Rails 5.2.5 (#7762) Generate votings access codes (#7704)
entantoencuanto
pushed a commit
that referenced
this pull request
Apr 7, 2021
entantoencuanto
added a commit
that referenced
this pull request
Apr 7, 2021
* develop: Revert "Fix single initiative type" (#7800) Census access codes exportation flow (#7756) Show attachment menu as active only when subitem is active (#7774) Add Voting Ballot Styles (#7779) Fix map accessibility issue - Map bottom position missing label (#7763) Update README.adoc (#7687) Fix single initiative type (#7667) Enable Proposals Cell to take into account machine translations (#7629) Change order by weight in subassemblies (#7620) Add categories parent filter to API (#7609) Mockup design for Remaining time in voting (#7597) Upgrade to Rails 5.2.5 (#7762) Generate votings access codes (#7704)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Right now we have a bottom position for the map indicated by an anchor element
<a>. It is missing a label which is required for all<a>elements. This changes the element to a<div>which doesn't require a label.This also makes sure that the bottom element ID is unique when there are multiple maps on the same page.
Also, I added accessibility + HTML validation tests for the map specs. They are now also testing the case with two separate maps on the same page.
📌 Related Issues
Testing
Run the modified map specs.
📋 Checklist
docs/.