Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show attachment menu as active only when subitem is active #7774

Merged
merged 1 commit into from Apr 6, 2021
Merged

Show attachment menu as active only when subitem is active #7774

merged 1 commit into from Apr 6, 2021

Conversation

orlera
Copy link
Contributor

@orlera orlera commented Mar 31, 2021 •
edited

🎩 What? Why?

After the major refactor of the menus, the Attachment menu entries for Voting and ParticipatoryProcess lost the active option, making them always active.

This PR sets them to be only active when one of their subitems is active.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

📷 Screenshots

BEFORE
The "Attachment" menu item is active even though we're on the "Info" tab

Screenshot 2021-03-31 at 09 41 57

AFTER

Screenshot 2021-03-31 at 09 40 39

♥️ Thank you!

@orlera orlera self-assigned this Mar 31, 2021
@mrcasals mrcasals marked this pull request as ready for review April 6, 2021 13:14
@mrcasals mrcasals added module: admin type: fix PRs that implement a fix for a bug module: elections module: participatory processes and removed type: fix PRs that implement a fix for a bug module: admin labels Apr 6, 2021
@mrcasals mrcasals merged commit 5fa6709 into develop Apr 6, 2021
@mrcasals mrcasals deleted the fix/attachemnt-menu-entry branch April 6, 2021 13:14
entantoencuanto added a commit that referenced this pull request Apr 6, 2021
@entantoencuanto
Merge branch 'develop' into chore/rails-6-upgrade
4a2a96c 
* develop:
  Census access codes exportation flow (#7756)
  Show attachment menu as active only when subitem is active (#7774)
  Add Voting Ballot Styles (#7779)
  Fix map accessibility issue - Map bottom position missing label (#7763)
  Update README.adoc (#7687)
  Fix single initiative type (#7667)
  Enable Proposals Cell to take into account machine translations (#7629)
  Change order by weight in subassemblies (#7620)
  Add categories parent filter to API (#7609)
  Mockup design for Remaining time in voting (#7597)
  Upgrade to Rails 5.2.5 (#7762)
  Generate votings access codes (#7704)
entantoencuanto pushed a commit that referenced this pull request Apr 7, 2021
@orlera @entantoencuanto
Show attachment menu as active only when subitem is active (#7774)
033ce27
entantoencuanto added a commit that referenced this pull request Apr 7, 2021
@entantoencuanto
Merge branch 'develop' into chore/rails-6-upgrade
3764411 
* develop:
  Revert "Fix single initiative type" (#7800)
  Census access codes exportation flow (#7756)
  Show attachment menu as active only when subitem is active (#7774)
  Add Voting Ballot Styles (#7779)
  Fix map accessibility issue - Map bottom position missing label (#7763)
  Update README.adoc (#7687)
  Fix single initiative type (#7667)
  Enable Proposals Cell to take into account machine translations (#7629)
  Change order by weight in subassemblies (#7620)
  Add categories parent filter to API (#7609)
  Mockup design for Remaining time in voting (#7597)
  Upgrade to Rails 5.2.5 (#7762)
  Generate votings access codes (#7704)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrcasals mrcasals mrcasals approved these changes

Assignees

@orlera orlera

Labels
module: elections module: participatory processes type: fix PRs that implement a fix for a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@orlera @mrcasals