Fix showing trustees menu on consultations module #7778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leio10
added
contract: e-voting
leio10
force-pushed
the
fix/consultations_trustees_menu
branch
from
117e21c
to
e238ca1
Compare
oriolgual
approved these changes
Apr 1, 2021
entantoencuanto
added a commit
that referenced
this pull request
Apr 5, 2021
* develop: fix: remove vote.js from elections manifest (#7795) Evote election log (#7757) Evote - identify with access code (#7740) Add unique trustee name (#7544) New translations en.yml (Finnish (plain)) (#7790) New Crowdin updates (#7754) Remove proposals dependency from the debates module (#7783) Make meetings functional without the proposals module (#7784) Make accountability functional without the proposals module (#7785) Make budgets functional without the proposals module (#7786) Remove BOM in CSV of private participants (#7781) Move searchlight gem to core and remove unnecessary requires (#7782) Admin voting census original load (csv) (#7591) Feat/evote count votes (#7769) Move votings answer results to its own table (#7767) Fix showing trustees menu on consultations module (#7778) Add missing assets to the elections manifest (#7773)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
The consultations participatory space doesn't have a components list, so the elections code to show the Trustees menu fails there. This PR fixes that.
This PR also modifies the consultations module to allow to see the Trustees menu in the questions if there is any Elections component. That doesn't seem to have much sense, and I don't like to name the menu as
:admin_question_menu, but it will keep the system consistent until we remove that module completely. Anyway, the source of the problem is that the question participatory space is calledquestioninstead ofconsultation_question, so this is a problem that we already had.📌 Related Issues
Link your PR to an issue
Testing
Describe the best way to test or validate your PR.
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.📷 Screenshots
Please add screenshots of the changes you're proposing
