Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make accountability functional without the proposals module #7785

Merged
merged 3 commits into from Apr 5, 2021
Merged

Make accountability functional without the proposals module #7785

merged 3 commits into from Apr 5, 2021

Conversation

ahukkanen
Copy link
Contributor

@ahukkanen ahukkanen commented Apr 2, 2021 •
edited

🎩 What? Why?

Same fix as #7784 but for the accountability module.

📌 Related Issues

Testing

See #7784

📋 Checklist

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

@oriolgual oriolgual merged commit e1f16fc into decidim:develop Apr 5, 2021
@ahukkanen ahukkanen deleted the fix/accountability-depends-on-proposals branch April 5, 2021 09:49
entantoencuanto added a commit that referenced this pull request Apr 5, 2021
@entantoencuanto
Merge branch 'develop' into chore/rails-6-upgrade
948825a 
* develop:
  fix: remove vote.js from elections manifest (#7795)
  Evote election log (#7757)
  Evote - identify with access code (#7740)
  Add unique trustee name (#7544)
  New translations en.yml (Finnish (plain)) (#7790)
  New Crowdin updates (#7754)
  Remove proposals dependency from the debates module (#7783)
  Make meetings functional without the proposals module (#7784)
  Make accountability functional without the proposals module (#7785)
  Make budgets functional without the proposals module (#7786)
  Remove BOM in CSV of private participants (#7781)
  Move searchlight gem to core and remove unnecessary requires (#7782)
  Admin voting census original load (csv) (#7591)
  Feat/evote count votes (#7769)
  Move votings answer results to its own table (#7767)
  Fix showing trustees menu on consultations module (#7778)
  Add missing assets to the elections manifest (#7773)
@leio10 leio10 added module: accountability type: fix PRs that implement a fix for a bug labels Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oriolgual oriolgual oriolgual approved these changes

Assignees
No one assigned
Labels
module: accountability type: fix PRs that implement a fix for a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ahukkanen @oriolgual @leio10