Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix not signed in needs permission redirect for internal links #7890

Merged
merged 2 commits into from Apr 27, 2021
Merged

Fix not signed in needs permission redirect for internal links #7890

merged 2 commits into from Apr 27, 2021

Conversation

ahukkanen
Copy link
Contributor

@ahukkanen ahukkanen commented Apr 26, 2021 •
edited

🎩 What? Why?

#7852 fixed the unauthenticated redirects to the sign in page for requests that do not have a referer (e.g. in email links).

But the requests still fail to redirect to the sign in page if the referer is defined (e.g. links/buttons within the site).

This fixes the unauthenticated user redirects to any resources that need permissions to the sign in page.

📌 Related Issues

Testing

  • Create an instance with a meetings component and meetings creation enabled for participants
  • Create a link on the process front page to the new meeting path (.../meetings/new) or use the step CTAs
  • See where the user is redirected to

📋 Checklist

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

@mrcasals mrcasals added module: core type: fix PRs that implement a fix for a bug labels Apr 27, 2021
@mrcasals mrcasals merged commit abb5cce into decidim:develop Apr 27, 2021
@ahukkanen ahukkanen deleted the fix/not-signed-in-needs-permission-redirect branch April 27, 2021 12:11
entantoencuanto added a commit that referenced this pull request Apr 30, 2021
@entantoencuanto
Merge branch 'develop' into active_storage_migration
c9d64f5 
* develop:
  Remove creation date from meeting card (#7922)
  Use NPM instead of yarn on CI (#7919)
  Validate nickname using correct regexp (#7900)
  Make webpacker build available in production (#7915)
  New Crowdin updates (#7911)
  Open attachments in new tab (#7912)
  Fix JS errors in the admin panel (#7903)
  Fix editor: remove br tags from inside a tags (#7901)
  Authorizable comment action for proposals (#6916)
  NoMethodError raised when voting comments from threads (#7880)
  Fix not signed in needs permission redirect for internal links (#7890)
  Fix meeting registrations questionnaire free text choice answers export (#7892)
  Store election verifiable results data in election (#7882)
  New Crowdin updates (#7884)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrcasals mrcasals mrcasals approved these changes

Assignees
No one assigned
Labels
module: core type: fix PRs that implement a fix for a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ahukkanen @mrcasals