Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix meeting registrations questionnaire free text choice answers export #7892

Conversation

ahukkanen
Copy link
Contributor

@ahukkanen ahukkanen commented Apr 27, 2021

🎩 What? Why?

When the meeting registrations form has a question with single or multiple choices and they have the free_text option defined for them, those free text answers won't be exported.

This fixes the issue by utilizing the Decidim::Forms::UserAnswersSerializer serializer to export the registration form answers.

Testing

  • Create a meeting with a registration form
  • Add a question to the form with the single choice or multiple choice types
  • For one of the answer options, enable the "free text" option
  • Submit an answer to the form with a free text choice answer
  • Export the meeting registrations from the admin panel
  • See that the free text answers are not exported correctly

📋 Checklist

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

@mrcasals mrcasals added module: meetings type: fix PRs that implement a fix for a bug labels Apr 27, 2021
@mrcasals mrcasals merged commit 193369b into decidim:develop Apr 27, 2021
@ahukkanen ahukkanen deleted the fix/meeting-registrations-questionnaire-answers-export branch April 27, 2021 12:10
entantoencuanto added a commit that referenced this pull request Apr 30, 2021
* develop:
  Remove creation date from meeting card (#7922)
  Use NPM instead of yarn on CI (#7919)
  Validate nickname using correct regexp (#7900)
  Make webpacker build available in production (#7915)
  New Crowdin updates (#7911)
  Open attachments in new tab (#7912)
  Fix JS errors in the admin panel (#7903)
  Fix editor: remove br tags from inside a tags (#7901)
  Authorizable comment action for proposals (#6916)
  NoMethodError raised when voting comments from threads (#7880)
  Fix not signed in needs permission redirect for internal links (#7890)
  Fix meeting registrations questionnaire free text choice answers export (#7892)
  Store election verifiable results data in election (#7882)
  New Crowdin updates (#7884)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: meetings type: fix PRs that implement a fix for a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants