Maps optional in meetings #7954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
entantoencuanto
force-pushed
the
7286-maps_optional_in_meetings
branch
from
4b8a287
to
218a676
Compare
entantoencuanto
force-pushed
the
7286-maps_optional_in_meetings
branch
from
218a676
to
abf0cd7
Compare
ahukkanen
reviewed
May 13, 2021
| @@ -1,6 +1,8 @@ | |||
| <%= render partial: "decidim/shared/component_announcement" %> | |||
|
|
|||
| <%= cell "decidim/meetings/meetings_map", search.results %> | |||
| <% if current_component.settings.maps_enabled? %> | |||
There was a problem hiding this comment.
Just an idea but could we also hide the map when there are no meetings with map pointers associated to them (online meetings only)?
There was a problem hiding this comment.
I think it's a good idea, if @decidim/product approves it I'll include the change
Yes, we agree! Let's include it then, thanks! |
leio10
added
module: meetings
type: feature
leio10
approved these changes
Jun 7, 2021
| @@ -95,6 +95,7 @@ class Meeting < Meetings::ApplicationRecord | |||
|
|
|||
| TYPE_OF_MEETING.each do |type| | |||
| scope type.to_sym, -> { where(type_of_meeting: type.to_sym) } | |||
| scope "not_#{type}".to_sym, -> { where.not(type_of_meeting: type.to_sym) } | |||
There was a problem hiding this comment.
💬 I think this is ok and I'd not change it now, but I feel we are rewriting enums here. 😕
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR:
📌 Related Issues
Testing
Describe the best way to test or validate your PR.
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.📷 Screenshots
Please add screenshots of the changes you're proposing
