Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport "Fix javascript exception when geocoding proposals is disabled" #8437

Merged
merged 1 commit into from
Oct 26, 2021

Conversation

alecslupu
Copy link
Contributor

🎩 What? Why?

Backport of : Fix javascript exception when geocoding proposals is disabled #8413

📌 Related Issues

Link your PR to an issue

  • Related to #?
  • Fixes #?

Testing

Describe the best way to test or validate your PR.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Description

♥️ Thank you!

@alecslupu alecslupu added the backport Pull Requests that are a backport for a fixed bug label Oct 25, 2021
@alecslupu alecslupu requested a review from leio10 October 25, 2021 15:10
@leio10 leio10 changed the base branch from develop to release/0.25-stable October 26, 2021 08:11
@andreslucena andreslucena changed the title [Backport 8413] Fix javascript exception when geocoding proposals is disabled Backport "Fix javascript exception when geocoding proposals is disabled" Oct 26, 2021
@leio10
Copy link
Contributor

leio10 commented Oct 26, 2021

@alecslupu the tests were not executed (probably because the base branch was wrong). Can you force the checks to be run? You can do it updating the commit message, merging the last branch changes or adding an empty commit. Thanks!

@leio10 leio10 added module: core type: fix PRs that implement a fix for a bug labels Oct 26, 2021
leio10
leio10 previously approved these changes Oct 26, 2021
@leio10 leio10 merged commit 90dc150 into decidim:release/0.25-stable Oct 26, 2021
@alecslupu alecslupu deleted the backport/8413 branch October 26, 2021 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Pull Requests that are a backport for a fixed bug module: core type: fix PRs that implement a fix for a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants