Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporarily ignore CSS validation issue in CI #8597

Merged
merged 1 commit into from
Dec 10, 2021
Merged

Temporarily ignore CSS validation issue in CI #8597

merged 1 commit into from
Dec 10, 2021

Conversation

ahukkanen
Copy link
Contributor

@ahukkanen ahukkanen commented Dec 10, 2021 •
edited

🎩 What? Why?

See #8596.

This adds a temporary fix to ignore this error until it is fixed upstream.

📌 Related Issues

Testing

See #8596 (or wait for the CI to be green).

📋 Checklist

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

@ahukkanen ahukkanen mentioned this pull request Dec 10, 2021
Closed
andreslucena
andreslucena approved these changes Dec 10, 2021
View reviewed changes
Copy link
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the issue report and the fast PR 👏🏽

@andreslucena andreslucena merged commit 6acc4ed into decidim:develop Dec 10, 2021
@ahukkanen ahukkanen deleted the fix/rspec-w3c-css-validation-issue branch December 10, 2021 11:50
entantoencuanto added a commit to PopulateTools/decidim that referenced this pull request Dec 10, 2021
@entantoencuanto
Merge branch 'fix/meetings_form_embed_type_visibility' into pwa-staging
4d14e17 
* fix/meetings_form_embed_type_visibility:
  Fix tests by adding missing doubled attributes
  Include value in validation conditional
  Allow participants to set iframe access level of meetings
  Fix embed type visibility in participants form
  Remove blank option in meetings embed type select
  Fix avatar thumbnail in participants' profile (decidim#8577)
  Fix HTML injection in comments and meeting's description (decidim#8511)
  Add search, filters and sorting to admin panel budget projects (decidim#8592)
  Add cache key separator to cache_hash (decidim#8559)
  Move social login buttons to the top of the login modal (decidim#8574)
  Fix the meeting copy functionality (decidim#8430)
  Temporarily ignore CSS validation issue in CI (decidim#8597)
  Fix security instructions (decidim#8587)
andreslucena pushed a commit that referenced this pull request Dec 13, 2021
@ahukkanen @andreslucena
Temporarily ignore CSS validation issue in CI (#8597)
4c02f70
@andreslucena andreslucena mentioned this pull request Dec 13, 2021
Merged
@andreslucena andreslucena added type: internal PRs that aren't necessary to add to the CHANGELOG for implementers and removed target: developer-experience labels Jan 10, 2022
@ahukkanen ahukkanen mentioned this pull request Aug 9, 2022
Merged
4 tasks
@ahukkanen ahukkanen mentioned this pull request Nov 2, 2022
Merged
@alecslupu alecslupu added this to the 0.26.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreslucena andreslucena andreslucena approved these changes

Assignees
No one assigned
Labels
type: internal PRs that aren't necessary to add to the CHANGELOG for implementers
Projects
None yet
Milestone
0.26.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ahukkanen @andreslucena @alecslupu