Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the meeting copy functionality #8430

Merged
merged 1 commit into from
Dec 10, 2021
Merged

Fix the meeting copy functionality #8430

merged 1 commit into from
Dec 10, 2021

Conversation

alecslupu
Copy link
Contributor

@alecslupu alecslupu commented Oct 24, 2021 •
edited

🎩 What? Why?

Adding support to hybrid and online meetings in copy meeting form. fixes #8099 .

📌 Related Issues

Link your PR to an issue

Testing

  1. Go to a meeting component admin
  2. Create an online meeting
  3. In the admin index press duplicate (you should see Url as mandatory, Address and location as optional)
  4. repeat the same process for hybrid (you should see the 3 fields as mandatory)

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Online meeting copy

♥️ Thank you!

@leio10 leio10 added in-review type: fix PRs that implement a fix for a bug labels Oct 26, 2021
@leio10 leio10 added this to Pending review from Product in Maintainers via automation Oct 26, 2021
leio10
leio10 previously approved these changes Oct 26, 2021
View reviewed changes
Copy link
Contributor

@leio10 leio10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

decidim-meetings/app/forms/decidim/meetings/admin/meeting_form.rb Show resolved Hide resolved
decidim-meetings/app/forms/decidim/meetings/admin/meeting_form.rb Show resolved Hide resolved
andreslucena
andreslucena previously approved these changes Oct 26, 2021
View reviewed changes
Copy link
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked it locally and works well!! 🚀

@andreslucena andreslucena changed the title Enhance the meeting copy functionality Fix the meeting copy functionality Oct 26, 2021
@alecslupu alecslupu dismissed stale reviews from andreslucena and leio10 via f2f93fb November 8, 2021 07:17
@andreslucena andreslucena moved this from Pending review from Product to To Review by Core in Maintainers Nov 11, 2021
@andreslucena andreslucena moved this from To Review by Core to In Review / Blocked / Waiting for feedback in Maintainers Nov 23, 2021
@andreslucena
Copy link
Member

I talked with @alecslupu on chat:

I will need to look into
i remember that the defined module is included in 3 places.. but the validations are being used in 2

Please ping me when this is ready to review again @alecslupu

@alecslupu
Copy link
Contributor Author

alecslupu commented Nov 23, 2021 •
edited by andreslucena

I talked with @alecslupu on chat:

I will need to look into
i remember that the defined module is included in 3 places.. but the validations are being used in 2

Please ping me when this is ready to review again @alecslupu

@andreslucena , please view comment : #8430 (comment), the PR should stay the way it is (I am thinking about the rule of 3).

andreslucena
andreslucena approved these changes Dec 10, 2021
View reviewed changes
Copy link
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽 Thanks for fixing this @alecslupu
We'll merge it when we have a green CI in develop`

@andreslucena andreslucena merged commit 875ea60 into decidim:develop Dec 10, 2021
Maintainers automation moved this from In Review / Blocked / Waiting for feedback to Done Dec 10, 2021
@andreslucena
Copy link
Member

As this is a fix, could you make a backport to v0.25-stable @alecslupu 🙏🏽? Thanks!

@andreslucena andreslucena moved this from Done to Backport pending in Maintainers Dec 10, 2021
@alecslupu alecslupu deleted the fix/8099 branch December 10, 2021 13:55
alecslupu added a commit to tremend-cofe/decidim that referenced this pull request Dec 10, 2021
@alecslupu
Fix the meeting copy functionality (decidim#8430)
a18d7e1
@alecslupu alecslupu mentioned this pull request Dec 10, 2021
Merged
12 tasks
entantoencuanto added a commit to PopulateTools/decidim that referenced this pull request Dec 10, 2021
@entantoencuanto
Merge branch 'fix/meetings_form_embed_type_visibility' into pwa-staging
4d14e17 
* fix/meetings_form_embed_type_visibility:
  Fix tests by adding missing doubled attributes
  Include value in validation conditional
  Allow participants to set iframe access level of meetings
  Fix embed type visibility in participants form
  Remove blank option in meetings embed type select
  Fix avatar thumbnail in participants' profile (decidim#8577)
  Fix HTML injection in comments and meeting's description (decidim#8511)
  Add search, filters and sorting to admin panel budget projects (decidim#8592)
  Add cache key separator to cache_hash (decidim#8559)
  Move social login buttons to the top of the login modal (decidim#8574)
  Fix the meeting copy functionality (decidim#8430)
  Temporarily ignore CSS validation issue in CI (decidim#8597)
  Fix security instructions (decidim#8587)
@andreslucena andreslucena moved this from Backport pending to Done in Maintainers Dec 14, 2021
@ahukkanen ahukkanen mentioned this pull request Aug 8, 2022
Closed
@alecslupu alecslupu added this to the 0.26.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreslucena andreslucena andreslucena approved these changes

@leio10 leio10 leio10 left review comments

Assignees
No one assigned
Labels
in-review module: meetings type: fix PRs that implement a fix for a bug
Projects
Maintainers
Done
Milestone
0.26.0
Development

Successfully merging this pull request may close these issues.

Cannot duplicate online-only meetings
3 participants
@alecslupu @andreslucena @leio10