Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ruby to 2.7.5 #8629

Merged
merged 1 commit into from Dec 20, 2021
Merged

Update ruby to 2.7.5 #8629

merged 1 commit into from Dec 20, 2021

Conversation

ferblape
Copy link
Contributor

@ferblape ferblape commented Dec 18, 2021 •
edited

🎩 What? Why?

Ruby version 2.7.5 is the last minor version published in the 2.7.x series. IMHO Decidim should run this version which fixes a few bugs and security issues of that series.

The transition should be really smooth, nothing should get broken, and code shouldn't be adapted to this version.

Hopefully the next PR of this type is the migration to Ruby 3 ❤️

📌 Related Issues

  • No issue related

Testing

  • IMHO if tests are ok, everything should be good

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

♥️ Thank you!

@ferblape ferblape marked this pull request as ready for review December 20, 2021 04:10
andreslucena
andreslucena approved these changes Dec 20, 2021
View reviewed changes
Copy link
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andreslucena andreslucena changed the title Bump to Ruby 2.7.5 Update ruby to 2.7.5 Dec 20, 2021
@andreslucena
Copy link
Member

Hopefully the next PR of this type is the migration to Ruby 3 heart

There's already an open PR for that one actually #8452

@andreslucena andreslucena added dependencies Pull requests that update a dependency file or issues that talk about updating dependencies target: developer-experience labels Dec 20, 2021
@andreslucena andreslucena merged commit 77d9423 into develop Dec 20, 2021
@andreslucena andreslucena deleted the chore/upgrade-ruby-2-7-5 branch December 20, 2021 09:07
@alecslupu
Copy link
Contributor

There's already an open PR for that one actually #8452

And it has a green pipeline.

@andreslucena andreslucena added type: internal PRs that aren't necessary to add to the CHANGELOG for implementers and removed target: developer-experience labels Jan 10, 2022
@andreslucena andreslucena mentioned this pull request Jun 17, 2022
Merged
12 tasks
@alecslupu alecslupu added this to the 0.26.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreslucena andreslucena andreslucena approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file or issues that talk about updating dependencies type: internal PRs that aren't necessary to add to the CHANGELOG for implementers
Projects
None yet
Milestone
0.26.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ferblape @andreslucena @alecslupu