Update ruby to 3.0

[alecslupu]

🎩 What? Why?

Upgrade Decidim to Ruby 3.0.2

♥️ Thank you!

[ferblape]

🚀

[ahukkanen]

@alecslupu You asked me previously about the problem with the attributes of type Rails::Engine. These changes need to be reverted (or changed to **{} in Ruby 3) for these attributes to work correctly.

This is explained in the CHANGELOG notes if you search for Rails::Engine from there.

There is a limitation in the Ruby language that if the method has default values for the previous arguments and defines keyword arguments, the last argument will always receive a respond_to?(:to_hash) call to it which doesn't work for Rails::Engine (you can try it out in the Rails console by calling Rails::Engine.respond_to?(:to_hash)).

EDIT:
Actually in Ruby 3 we just need to pass the hash as an empty keyword argument list as **{}. I'll modify my comments below.

[ahukkanen]

@alecslupu Can you rebase this with develop please? 🙏

I'd like to get rid of the deprecation messages to review this properly.

[ahukkanen]

I'm not sure what to do about these but I would rather try to push these changes to the upstream repositories of these gems.

The Origami gem seems stale at the moment, though...

[ahukkanen]

I can reproduce this.

Thanks @andreslucena for confirming!

I believe this has something to do with the version of Webpacker we are using not being thread safe.

If I do the following change at development_app/config/puma.rb:

# Comment this out:
# threads min_threads_count, max_threads_count
# Add this instead:
threads 1, 1

Then I cannot make this break anymore.

It has something to do webpacker trying to process the javascript_pack_tag or stylesheet_pack_tag concurrently in multiple threads.

[alecslupu]

I can reproduce this.

Thanks @andreslucena for confirming!

I believe this has something to do with the version of Webpacker we are using not being thread safe.

If I do the following change at development_app/config/puma.rb:

# Comment this out:
# threads min_threads_count, max_threads_count
# Add this instead:
threads 1, 1

Then I cannot make this break anymore.

It has something to do webpacker trying to process the javascript_pack_tag or stylesheet_pack_tag concurrently in multiple threads.

Wow, Nice catch.

It seems that I already had the number of threads set to 1, 1, and this was the reason i could not replicate it.

@ahukkanen, Webpacker hits us again >:) ... Maybe it would make sense to continue the discussion about the import maps or alternatives.

[ahukkanen]

The chdir issue seems to be Ruby 3 related, so we need to resolve this.

The reason why it hasn't failed "hard" with Ruby 2.x is this:
ruby/ruby#3591

They changed the conflicting chdir from warning to a RuntimeError in Ruby 3.

This is further explained here:
rails/webpacker#2801

I also found a commit in Shakapacker which fixes this issue (at least judging by the commit message):
shakacode/shakapacker@f2dc437

This fix seems to be similar to what is explained in that webpacker issue linked above.

[ahukkanen]

@ahukkanen, Webpacker hits us again >:) ... Maybe it would make sense to continue the discussion about the import maps or alternatives.

@alecslupu @andreslucena I am adding the proposed monkey patch in the related issue at #9203. Once we get that merged, we should be finally able to merge this one.

[andreslucena]

@alecslupu @andreslucena I am adding the proposed monkey patch in the related issue at #9203. Once we get that merged, we should be finally able to merge this one.

I've just reviewed and merged it.

[ahukkanen]

This is good to go now after we got that thread safety issue resolved.

Can you also give your review @andreslucena to indicate @alecslupu that this is ready to be merged and we can revert the lines that we need to revert before merging.

[andreslucena]

I've just give it a last spin locally and it's fine for me 👍🏽

[andreslucena]

@alecslupu you can revert the lines anytime you can

[ahukkanen]

@alecslupu Sorry there is still missing specs because of another recently merged PR: #8866.

The problem is on this line:

decidim/decidim-admin/app/views/decidim/admin/participatory_space_private_users_csv_imports/new.html.erb

Line 9 in d283907

<p> <%= t(".destroy.explanation", { count: @count }) %>

I'll fix it in another PR shortly.

[alecslupu]

I was just looking on it ... and fixing from my end... but if you want to merge, to let it become Core, then i am okay with that

[ahukkanen]

I was just looking on it ... and fixing from my end... but if you want to merge, to let it become Core, then i am okay with that

Should be fixed by #9218.

[ahukkanen]

@alecslupu Can you merge with develop please? Let's see that the CI is green and then we can finally merge this. 🤞

[alecslupu]

@ahukkanen the pipeline is Green :)

[ahukkanen]

Enormous work here @alecslupu, many thanks to you and everyone involved! And thanks for the great patience with all the related issues and changes.

I've just merged with develop and let's see that the generators CI also passes after this.